[7.x] [Graph] Save modal (#44261) #44918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create graph listing page * clean up app folder * remove inline loading menu * also add badge to workspace route * fix tests * fix graph spaces functional test * generate documentation for new breadcrumb property * fix test subject names * remove unused translations * start implementing save modal flow for Graph * fix spaces functional test * wip save modal * wip save modal * add and style save modal * add placeholder to description field * disable dirty check on breadcrumb navigation and fix delete function * improve onClick typing on breadcrumb * fix newline error and use new types in dashboard app controller * fix translation errors * fix i18n translation for real * code review * fix i18n phrases * remove fragments * remove unnecessary max-width and add commentary * move to async syntax * clean up implementation * use description instead of title * fix snapshot * adress review comments and set width for all save modals * fix bug and improve typing * fix classname
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: