Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsvb.asciidoc #44913

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Update tsvb.asciidoc #44913

merged 3 commits into from
Oct 11, 2019

Conversation

nagstaku
Copy link

@nagstaku nagstaku commented Sep 5, 2019

Updates in TSVB docs to assist with (#13433). I was very confused when I plugged in some data, saw it display in my table, and then came back a couple hours later and it was gone, despite my time range at the top being wide enough to encompass the data.

[skip ci]

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

to assist with (elastic#13433) documentation. I was very confused when I plugged in some data, saw it display in my table, and then came back a couple hours later and it was gone, despite my time range at the top being wide enough to encompass the data.
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@@ -40,6 +40,8 @@ image:images/tsvb-markdown.png["Markdown visualization"]

Table:: Display data from multiple time series by defining the field group to show in the rows, and the columns of data to display.

Only the latest number in a data series will be shown. Under Panel Options > Interval the series length can be defined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the second sentence, would you mind changing it to:

To define the series length, select Panel options, then enter the Interval.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

@KOTungseth KOTungseth added release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v7.4.0 v7.5.0 labels Oct 10, 2019
@KOTungseth
Copy link
Contributor

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

update per review
@nagstaku
Copy link
Author

@KOTungseth Committed that fix, and I don't think it needs a manual Jenkins build kicked off? I see this in the "All checks have passed" dialog:

Docs only change detected, CI is not required

@KOTungseth
Copy link
Contributor

@nagstaku I've relocated this content to the task below it. Thank you for your work on this!

@KOTungseth KOTungseth merged commit 321736b into elastic:7.3 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v7.4.0 v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants