[Logs UI] Preserve relative dates selected in the Logs Analysis page datepicker #44706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
bug
|
Pinging @elastic/infra-logs-ui |
💚 Build Succeeded |
weltenwort
added
the
release_note:skip
|
@Kerry350 FYI, I just merged |
💚 Build Succeeded |
Kerry350
approved these changes
Sep 5, 2019
My bad for creating a bad example on the logs stream page... it's still happening there 🙈 |
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Sep 5, 2019
…c#44706) This changes the type of the state used to store the dates selected via the datepicker in the URL to string. That means it preserves the occurrences of now, now-2w and similar date math expressions without eagerly converting them to a specific timestamp. In combination with the fact that the analysis results page now keeps the selected date range as strings and the query date range as separate numeric timestamps, this fixes the usage of the relative time ranges in the datepicker in combination with the auto-reload functionality of the datepicker. Additionally the page now makes use of the fixed auto-reloading by enabling it by default with a 30 second interval to make the onboarding smoother. The "no data" message on the results page will now be replaced by the chart as soon as the log rate analysis job has started producing results. It further fixes the rounding of the end date to round up. That means that the quick select intervals like "This year" or "This week" actually work and result in a non-empty interval.
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Sep 5, 2019
…c#44706) This changes the type of the state used to store the dates selected via the datepicker in the URL to string. That means it preserves the occurrences of now, now-2w and similar date math expressions without eagerly converting them to a specific timestamp. In combination with the fact that the analysis results page now keeps the selected date range as strings and the query date range as separate numeric timestamps, this fixes the usage of the relative time ranges in the datepicker in combination with the auto-reload functionality of the datepicker. Additionally the page now makes use of the fixed auto-reloading by enabling it by default with a 30 second interval to make the onboarding smoother. The "no data" message on the results page will now be replaced by the chart as soon as the log rate analysis job has started producing results. It further fixes the rounding of the end date to round up. That means that the quick select intervals like "This year" or "This week" actually work and result in a non-empty interval.
weltenwort
added a commit
that referenced
this pull request
Sep 5, 2019
weltenwort
added a commit
that referenced
this pull request
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the type of the state used to store the dates selected via the datepicker in the URL to string. That means it preserves the occurrences of
now,now-2wand similar date math expressions without eagerly converting them to a specific timestamp. In combination with the fact that the analysis results page now keeps the selected date range as strings and the query date range as separate numeric timestamps, this fixes the usage of the relative time ranges in the datepicker in combination with the auto-reload functionality of the datepicker.Additionally this PR makes use of the fixed auto-reloading by enabling it by default with a 30 second interval to make the onboarding smoother. The "no data" message on the results page will now be replaced by the chart as soon as the log rate analysis job has started producing results.
It further fixes the rounding of the end date to round up. That means that the quick select intervals like "This year" or "This week" actually work and result in a non-empty interval.
fixes #44670
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenarios