-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed TSVB Panel Options failure #44573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
added
the
bug
Fixes for quality problems that affect the customer experience
label
Sep 1, 2019
Pinging @elastic/kibana-app-arch |
lizozom
changed the title
Fixed failure due to missing fail object client
Fixed TSVB Panel Options failure
Sep 1, 2019
lizozom
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Sep 1, 2019
💔 Build Failed |
retest |
💚 Build Succeeded |
LGTM. Thanks! |
alexwizp
approved these changes
Sep 2, 2019
alexwizp
approved these changes
Sep 2, 2019
ppisljar
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Sep 2, 2019
This was referenced Sep 2, 2019
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Sep 2, 2019
lizozom
pushed a commit
that referenced
this pull request
Sep 2, 2019
lizozom
pushed a commit
that referenced
this pull request
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:NP Migration
release_note:skip
Skip the PR/issue when compiling release notes
review
v7.4.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Navigating to TSVB > Panel Options is failing, due to an argument not being passed to the context, after merging this PR.
This failure should have been caught by the flaky test, that was disabled a day before merging my PR :-( @spalger
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers