[ML] Data frame analytics: Fix source index checks. #44479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
peteharverson
approved these changes
Aug 30, 2019
| // based on code used by `ui/index_patterns` internally | ||
| // remove the space character from the list of illegal characters | ||
| INDEX_PATTERN_ILLEGAL_CHARACTERS.pop(); | ||
| const characterList = INDEX_PATTERN_ILLEGAL_CHARACTERS.join(', '); |
There was a problem hiding this comment.
Do you need to be checking against this list of characters, as the control for selecting the source index is a dropdown which list the Kibana index patterns, so presumably this check was done when the index pattern was created? So really the form just needs to be checking that the source index hasn't been left empty.
| ]) | ||
| !sourceIndexNameEmpty && | ||
| !sourceIndexNameValid && [ | ||
| <Fragment> |
There was a problem hiding this comment.
As above, this should never be shown as you can only select a valid KIbana index pattern as the source index.
💔 Build Failed |
💔 Build Failed |
|
@peteharverson You're right about the checks in your comments. This was originally done because the very first version was just a plain text input field. I'll leave it in for now because there will be more updates to this (e.g. support for saved searches). Once all features are in and the code is still not necessary I'll remove it. |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 2, 2019
The source index selection is based in Kibana index patterns. The form validation was too strict in that regard and used the same check as the destination index. - Removes the check if the source index exists, it's not practical with index patterns containing wildcards. - Changes the name validation to use the Kibana index pattern name check.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 2, 2019
The source index selection is based in Kibana index patterns. The form validation was too strict in that regard and used the same check as the destination index. - Removes the check if the source index exists, it's not practical with index patterns containing wildcards. - Changes the name validation to use the Kibana index pattern name check.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 2, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (409 commits) [ML] Data frame analytics: Fix source index checks. (elastic#44479) [Code] try fix this test (elastic#43692) skip flaky suite (elastic#44572) (elastic#42111) (elastic#44286) (elastic#43557) (elastic#42567) skip flaky suite (elastic#44560) skip flaky suite (elastic#44250) disable flaky suite (elastic#41336) [code] Update download URLs for go lsp. (elastic#44581) disable flaky suite (elastic#44575) disable flaky suite (elastic#44576) [Code] add functional test to verify lang server full api symbol/reference counts (elastic#44051) Improve Storybook scripts and load time (elastic#44511) Update Dependencies (elastic#44519) Remove use of injecti18n in Embeddables plugin (elastic#44043) [SIEM] Adds a configuraton option for the default SIEM date time range (elastic#44540) [Uptime]Fix/issue 40584 section headline should be inside panel (elastic#43468) disable flaky suite (elastic#22322) Changes network to use ECS fields (elastic#44392) Fix 'workpad flash' when loading new workpad (elastic#44387) [renovate] bump new PR version labels Update dependency cmd-shim to ^2.1.0 (elastic#44034) ... # Conflicts: # src/legacy/core_plugins/console/public/index.html
walterra
added a commit
that referenced
this pull request
Sep 2, 2019
The source index selection is based in Kibana index patterns. The form validation was too strict in that regard and used the same check as the destination index. - Removes the check if the source index exists, it's not practical with index patterns containing wildcards. - Changes the name validation to use the Kibana index pattern name check.
walterra
added a commit
that referenced
this pull request
Sep 2, 2019
The source index selection is based in Kibana index patterns. The form validation was too strict in that regard and used the same check as the destination index. - Removes the check if the source index exists, it's not practical with index patterns containing wildcards. - Changes the name validation to use the Kibana index pattern name check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The source index selection is based in Kibana index patterns. The form validation was too strict in that regard and used the same check as the destination index.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosFor maintainers