Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] add skipCloud for all code function tests #44334

Merged
merged 1 commit into from
Aug 29, 2019
Merged

[Code] add skipCloud for all code function tests #44334

merged 1 commit into from
Aug 29, 2019

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Aug 28, 2019

Summary

#39386

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@mw-ding mw-ding added v8.0.0 Team:Code release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Aug 28, 2019
@mw-ding mw-ding requested a review from zfy0701 August 28, 2019 21:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/code

@mw-ding mw-ding requested a review from liza-mae August 28, 2019 21:19
@mw-ding mw-ding mentioned this pull request Aug 28, 2019
Closed
liza-mae
liza-mae approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mw-ding
Copy link
Contributor Author

mw-ding commented Aug 28, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding
Copy link
Contributor Author

mw-ding commented Aug 29, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mw-ding mw-ding merged commit 8952e57 into elastic:master Aug 29, 2019
@mw-ding mw-ding deleted the skip-cloud-func-test branch August 29, 2019 22:59
This was referenced Aug 29, 2019
Merged
Merged
mw-ding added a commit that referenced this pull request Aug 30, 2019
@mw-ding
[Code] add skipCloud for all code function tests (#44334) (#44449)
fb451bb
mw-ding added a commit that referenced this pull request Aug 30, 2019
@mw-ding
[Code] add skipCloud for all code function tests (#44334) (#44443)
332187d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liza-mae liza-mae liza-mae approved these changes

@zfy0701 zfy0701 zfy0701 approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mw-ding @elasticmachine @zfy0701 @liza-mae