Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup unskip test - test 30 times on CI #44304

Merged
merged 14 commits into from
Aug 30, 2019
Merged

Rollup unskip test - test 30 times on CI #44304

merged 14 commits into from
Aug 30, 2019

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Aug 28, 2019 •
edited
Loading

This test was skipped and now after isolating it in CI and running multiple times, it passes. Re-adding it back.

@rashmivkulkarni rashmivkulkarni self-assigned this Aug 28, 2019
@rashmivkulkarni rashmivkulkarni added the release_note:skip Skip the PR/issue when compiling release notes label Aug 28, 2019
@dmlemeshko
Copy link
Member

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@rashmivkulkarni
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@dmlemeshko
Copy link
Member

Rashmi, you can actually exclude intake jobs since you are interested in x-pack ciGroup1 only

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@rashmivkulkarni
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeeDr LeeDr self-requested a review August 30, 2019 14:04
@rashmivkulkarni rashmivkulkarni requested review from dmlemeshko and removed request for LeeDr August 30, 2019 14:04
LeeDr
LeeDr approved these changes Aug 30, 2019
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this PR just unskips a previously skipped test. We believe the cause of the failure was fixed in another PR related to retries on settings updates.

@rashmivkulkarni rashmivkulkarni requested a review from LeeDr August 30, 2019 14:04
@dmlemeshko dmlemeshko self-requested a review August 30, 2019 16:10
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@rashmivkulkarni rashmivkulkarni merged commit 382733b into elastic:master Aug 30, 2019
@cjcenizal cjcenizal changed the title [WIP] Rollup unskip test - test 30 times on CI Rollup unskip test - test 30 times on CI Aug 30, 2019
@rashmivkulkarni rashmivkulkarni mentioned this pull request Aug 30, 2019
Closed
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Aug 30, 2019
@rashmivkulkarni
[WIP] Rollup unskip test - test 30 times on CI (elastic#44304)
8567199 
fixes elastic#43559
@rashmivkulkarni rashmivkulkarni mentioned this pull request Aug 30, 2019
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Aug 30, 2019
@rashmivkulkarni
[WIP] Rollup unskip test - test 30 times on CI (elastic#44304)
8182d1f 
fixes elastic#43559
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

rashmivkulkarni added a commit that referenced this pull request Aug 30, 2019
@rashmivkulkarni
Rollup unskip test - test 30 times on CI (#44304) (#44535)
ea7d55f 
fixes #43559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@LeeDr LeeDr Awaiting requested review from LeeDr

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashmivkulkarni @dmlemeshko @elasticmachine @LeeDr