Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixing job type picker tests #44275

Merged

Conversation

jgowdyelastic
Copy link
Member

Missing data-test-subj in the job type picker html causes test failures.
This was originally missed on master by coincidental timing of the tests being enabled with this commit
#43017 (comment)

However it caused failures on a 7.x backport which had to be addressed in the backport (#44254)

Therefore this PR does not need to be backported to 7.x.

@jgowdyelastic jgowdyelastic added review test non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 28, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 28, 2019 15:44
@jgowdyelastic jgowdyelastic self-assigned this Aug 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@spalger
Copy link
Contributor

spalger commented Aug 28, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review test v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants