Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Save modal #44261

Merged
merged 39 commits into from
Sep 5, 2019
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
067158a
create graph listing page
flash1293 Aug 26, 2019
5fddc10
clean up app folder
flash1293 Aug 26, 2019
95f003b
remove inline loading menu
flash1293 Aug 27, 2019
ae44388
also add badge to workspace route
flash1293 Aug 27, 2019
2f1056f
fix tests
flash1293 Aug 27, 2019
5d637f5
fix graph spaces functional test
flash1293 Aug 27, 2019
9d17862
generate documentation for new breadcrumb property
flash1293 Aug 27, 2019
db1d740
fix test subject names
flash1293 Aug 27, 2019
e09b70d
remove unused translations
flash1293 Aug 27, 2019
2dab994
start implementing save modal flow for Graph
flash1293 Aug 27, 2019
c34d845
fix spaces functional test
flash1293 Aug 27, 2019
2d775e6
wip save modal
flash1293 Aug 27, 2019
ebe80d1
wip save modal
flash1293 Aug 27, 2019
fab1577
add and style save modal
flash1293 Aug 28, 2019
a9d31c8
add placeholder to description field
flash1293 Aug 28, 2019
9d2822e
Merge remote-tracking branch 'upstream/master' into graph/listing-page
flash1293 Aug 28, 2019
d0b9247
Merge remote-tracking branch 'upstream/master' into graph/listing-page
flash1293 Aug 29, 2019
d187eae
disable dirty check on breadcrumb navigation and fix delete function
flash1293 Aug 29, 2019
21ba056
Merge branch 'graph/listing-page' into graph/savemodal
flash1293 Aug 29, 2019
a289d7d
improve onClick typing on breadcrumb
flash1293 Aug 29, 2019
989481c
Merge branch 'graph/listing-page' into graph/savemodal
flash1293 Aug 29, 2019
be1e59a
fix newline error and use new types in dashboard app controller
flash1293 Aug 29, 2019
c5ac49b
fix translation errors
flash1293 Aug 30, 2019
8d6cec1
fix i18n translation for real
flash1293 Aug 30, 2019
0472505
Merge remote-tracking branch 'upstream/master' into graph/savemodal
flash1293 Aug 30, 2019
173804a
code review
flash1293 Sep 2, 2019
54e9a7b
Merge remote-tracking branch 'upstream/master' into graph/savemodal
flash1293 Sep 2, 2019
6f1bbca
fix i18n phrases
flash1293 Sep 2, 2019
7c94337
remove fragments
flash1293 Sep 2, 2019
f489b07
Merge remote-tracking branch 'upstream/master' into graph/savemodal
flash1293 Sep 4, 2019
bcc280f
remove unnecessary max-width and add commentary
flash1293 Sep 5, 2019
a578814
move to async syntax
flash1293 Sep 5, 2019
4897b52
clean up implementation
flash1293 Sep 5, 2019
7b2b91b
use description instead of title
flash1293 Sep 5, 2019
208b4db
Merge remote-tracking branch 'upstream/master' into graph/savemodal
flash1293 Sep 5, 2019
e4b9aa0
fix snapshot
flash1293 Sep 5, 2019
1195f36
adress review comments and set width for all save modals
flash1293 Sep 5, 2019
372f3b4
fix bug and improve typing
flash1293 Sep 5, 2019
3de7e4f
fix classname
flash1293 Sep 5, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix classname
flash1293 committed Sep 5, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 3de7e4fe603b5727d03aa4968378c6b152fd5976

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
.saveModal {
.kbnSavedObjectSaveModal {
width: $euiSizeXXL * 10;
}
Original file line number Diff line number Diff line change
@@ -80,7 +80,7 @@ export class SavedObjectSaveModal extends React.Component<Props, State> {
<form onSubmit={this.onFormSubmit}>
<EuiModal
data-test-subj="savedObjectSaveModal"
className="saveModal"
className="kbnSavedObjectSaveModal"
onClose={this.props.onClose}
>
<EuiModalHeader>