Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show color schema selection for heatmap tile maps #44260

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Don't show color schema selection for heatmap tile maps #44260

merged 4 commits into from
Sep 3, 2019

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Aug 28, 2019 •
edited
Loading

Summary

Fix #42826

Hide Color schema select while mapType is Heatmap

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@sulemanof sulemanof added the release_note:skip Skip the PR/issue when compiling release notes label Aug 28, 2019
@spalger
Copy link
Contributor

spalger commented Aug 28, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes requested review from a team and removed request for timroes August 30, 2019 13:04
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

nreese
nreese approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review and tested changes in chrome

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata added Feature:Vis Editor Visualization editor issues v7.5.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@maryia-lapata maryia-lapata merged commit 4a1d346 into elastic:master Sep 3, 2019
@maryia-lapata maryia-lapata mentioned this pull request Sep 3, 2019
Merged
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Sep 3, 2019
@sulemanof @maryia-lapata
Don't show color schema selection for heatmap tile maps (elastic#44260)
708f483
maryia-lapata added a commit that referenced this pull request Sep 4, 2019
@maryia-lapata
Don't show color schema selection for heatmap tile maps (#44260) (#44663
c4e6fa7 
)
@sulemanof sulemanof deleted the fix/hide_color_schema branch September 16, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backported Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't show color schema selection for heatmap tile maps
5 participants
@sulemanof @spalger @elasticmachine @nreese @maryia-lapata