[7.x] [Rollup] Metrics multiple selection (#42927) #43353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove duplicate columns declaration * First iteration of select all menu working * A lot of bugfixes and started on row-level selection using flatMap * Wip on row selection * Fix formatting * More bug fixes and and first iteration of row selection and column selection working * Minor refactors, cleaned up logging. Still has nasty UX bug on Popover menu * Added translations and empty tests * Tests are WiP * Move checkboxes out of popover * Implemented first iteration of select all functionality * Move row select all into checkbox area * Remove unused code and simplify select all if-else * First iteration of tests * fix tests and update name data-test-subj name * Move checkboxes into popover with button * - Fix tests - Refactor test helpers for metric step - Cleanup some JS style nits - Make popover button disabled if all metric checkboxes are disabled * Remove extra newline * - Moved constants from metrics to own file so that it's more re-usable - Removed unnecessary styling - Fixed typos - Updated comments - i18n
💔 Build Failed |
|
Retest |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: