-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console to NP ready #43346
Merged
jloleysens
merged 42 commits into
elastic:master
from
jloleysens:chore/console-to-np-ready
Sep 12, 2019
Merged
Console to NP ready #43346
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
34ae77d
General structure of Public w/ legacy brace + autocomplete 🤔
jloleysens a6c4045
First refactor of kbn ace keyboard mode to TS+React
jloleysens bc36ca0
clean up unused props
jloleysens 8983ae8
console_menu.js -> console_menu.tsx
jloleysens b99749d
Remove unused file from quarantine and added fixed ui ace keyboard mo…
jloleysens 7cf1417
- Refactored history and storage to app-wide services
jloleysens 8ff783a
A lot of cleanup, re-introduced editor resize checker, re-introduced …
jloleysens 32c4633
First iteration of tap nav menu, with history toggle working
jloleysens 1969e66
Lots of fixes
jloleysens d819528
Moved a lot of files around again, tidied up NP set up
jloleysens 45382c3
Replace angular directive
jloleysens 18f84a2
Remove used code
jloleysens 51daf28
Re-order imports and move all ace dependencies to same location
jloleysens 6bccd55
Remove more unused code
jloleysens 6a5f082
Revise quarantined setup mocks
jloleysens a6b8750
Merge branch 'master' of github.com:elastic/kibana into chore/console…
jloleysens c5b2841
Don't suggest 'undefined' or other null-like values in autocomplete
jloleysens 605f16a
Clean up api_server folder
jloleysens 21c9168
Re-add missing style
jloleysens d5b2702
Updated karma spec mock
jloleysens b59a2b2
Fix editors cutting of at bottom of screen
jloleysens 8764ab0
Refactor console editors into single components
jloleysens 012d760
Updated use of contexts with better error message
jloleysens 2b2509c
Updated test mocks
jloleysens 758064d
Update to be more in line with NP conventions https://github.com/elas…
jloleysens 3130343
Update console history when making new requests
jloleysens 213bbdc
Merge branch 'master' of github.com:elastic/kibana into chore/console…
jloleysens 0a8648b
Merge branch 'chore/console-to-np-ready' of github.com:jloleysens/kib…
jloleysens 477e8f2
Clean up git merge conflict artifact
jloleysens 60f23cb
Use updated NP interfaces
jloleysens 322569f
More typings fixed after updating local project dependencies
jloleysens 384f4de
Removing some dependencies on KUI and font awesome from legacy editor
jloleysens 683a04e
Fix clear history not re-rendering
jloleysens e143c64
Simplify split_panel and add tests
jloleysens e0fcb29
Fix accessibility tabbing behaviour for ace editor
jloleysens 0939758
Refactor ConsoleEditor into two separate components
jloleysens d1824b3
Merge branch 'master' of github.com:elastic/kibana into chore/console…
jloleysens 2e531e9
Merge branch 'master' of github.com:elastic/kibana into chore/console…
jloleysens e351ba2
Major a11y fix when tabbing
jloleysens c82003c
Merge branch 'master' of github.com:elastic/kibana into chore/console…
jloleysens 7f65525
Merge branch 'master' of github.com:elastic/kibana into chore/console…
jloleysens 08a9df0
Update comment
jloleysens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
General structure of Public w/ legacy brace + autocomplete 🤔
Refactor Resizer functionality (panel component) Refactor Play Button Refactor Auto-completion Refactor Docs opener Refactor Storage
- Loading branch information
commit 34ae77dd66edbde11a6fb22c928be8decfd81be8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
## New Platform (NP) Ready vs Quarantined | ||
|
||
We want to move toward more modularised code in the Console app. | ||
Part of the effort means separating out different console compoonents | ||
like: | ||
|
||
- The language parser | ||
- The editor rendering component | ||
- Autocomplete | ||
- The UI container components | ||
|
||
In addition to this effort we want to bring Console in line with NP | ||
requirements and ensure that we are not using NG in this app anymore. | ||
|
||
The quarantined folder contains all of the code that has been cleared | ||
for living in the new platform as it has not been properly refactored | ||
or has dependencies on, for example, UI public. | ||
|
||
Over time, the quarantined part of the code should shrink to nothing | ||
jloleysens marked this conversation as resolved.
Show resolved
Hide resolved
|
||
and we should only have NP ready code. |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"id": "console", | ||
"version": "kibana", | ||
"server": true, | ||
jloleysens marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"ui": true | ||
} |
20 changes: 20 additions & 0 deletions
20
src/legacy/core_plugins/console/public/np_ready/public/app/components/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
export * from './split_panel'; |
37 changes: 37 additions & 0 deletions
37
..._plugins/console/public/np_ready/public/app/components/split_panel/components/resizer.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import React from 'react'; | ||
|
||
type ResizerMouseEvent = React.MouseEvent<HTMLDivElement, MouseEvent>; | ||
|
||
export interface Props { | ||
onMouseDown: (eve: ResizerMouseEvent) => void; | ||
} | ||
|
||
/** | ||
* TODO: This component uses styling constants from public UI - should be removed, next iteration should incl. horizontal and vertical resizers. | ||
*/ | ||
export function Resizer(props: Props) { | ||
return ( | ||
<div {...props} className="conApp__resizer"> | ||
︙ | ||
</div> | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this point to anything? I am not seeing the webpackShims folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, @cjcenizal do you know anything more about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. Can we double-check with the Platform and Operations teams? I see
webpackShims
in the root, but clearly the path here doesn't make sense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with how this works or what it does. @spalger do you have more info on webpackShims and the
noParse
uiExport?