[Maps] reposition tooltip when tooltip size changes #43152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💚 Build Succeeded |
x-pack/legacy/plugins/maps/public/connected_components/map/feature_properties.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
thomasneirynck
approved these changes
Aug 13, 2019
x-pack/legacy/plugins/maps/public/connected_components/map/mb/view.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Aug 13, 2019
* [Maps] reposition tooltip when tooltip size changes * review feedback * fix jest tests * add check to ensure tooltip state location is still provided
nreese
added a commit
that referenced
this pull request
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where tooltip content gets clipped by map boundary when dynamic content loads, like when the properties load. This is really needed by #43141 because the create filter form is pretty tall and can result in cut off tooltips quite often
Fixes issues like below by having map box recalculate the tooltip anchor when tooltip content changes