Fix date_nanos formatting for formats without fractional seconds #43114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
💚 Build Succeeded |
kertal
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
TinaHeiligers
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
I pulled in the code and tested it in Chrome. The error are described in the issue is gone. On a completely different matter, I did notice that the Update button in the search bar in Discover now says Uodate. However, the search bar was not touched in this PR.
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Aug 21, 2019
…stic#43114) * Fix formatting for formats without S... part * Add jest test catching the bug
|
@TinaHeiligers thx for that quick review! |
kertal
added a commit
that referenced
this pull request
Aug 23, 2019
) (#43718) * Fix formatting for formats without S... part * Add jest test catching the bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes an exception when you configure a date nanos format without fractional second part (SSS...)
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support-[ ] Documentation was added for features that require explanation or tutorials-[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately