[FTR] Refactor mocha under @kbn/test #42862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
under kbn-test, with needed exports/imports.
wayneseymour
added
release_note:skip
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
in KIBANA/scripts/mocha.js. Also, fixup cwd for globby as we are exec-ing from a different directory.
💚 Build Succeeded |
💚 Build Succeeded |
jbudz
approved these changes
Aug 15, 2019
|
Thanks @jbudz |
|
@wayneseymour, this was never backported. Would you mind looking into what would be needed to ensure consistency between the 7.x branch and master? |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Nov 13, 2020
* Run prettier on the files that will be refactored under @kbn/test, in a follow-up pr. * Fixup all paths to mocha, under kbn-test, with needed exports/imports. * Fixed borked path (bad refactor). * Fixup one more borked path. * Fixup tsconfig for xml.ts * Drop setup_node_env as it's already in KIBANA/scripts/mocha.js. Also, fixup cwd for globby as we are exec-ing from a different directory.
|
@wayneseymour, I opened a backport #83369 |
tylersmalley
pushed a commit
that referenced
this pull request
Nov 13, 2020
* Run prettier on the files that will be refactored under @kbn/test, in a follow-up pr. * Fixup all paths to mocha, under kbn-test, with needed exports/imports. * Fixed borked path (bad refactor). * Fixup one more borked path. * Fixup tsconfig for xml.ts * Drop setup_node_env as it's already in KIBANA/scripts/mocha.js. Also, fixup cwd for globby as we are exec-ing from a different directory. Co-authored-by: Tre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another refactor of
thingsthat should liveunder @kbn/test.