Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API endpoint to Rollup Job JSON summary. #42789

Merged

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Aug 6, 2019

Release note

This is a minor enhancement to display the underlying Elasticsearch endpoint in the Rollup Job Wizard. Users can copy and paste this endpoint and payload to execute the request manually or use it within a script or other automated system.

image

Other changes

This PR also brings the ILM request flyout inline with this design.

image

@cjcenizal cjcenizal added release_note:enhancement v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Rollups v7.4.0 labels Aug 6, 2019
@cjcenizal cjcenizal requested a review from jen-huang August 6, 2019 22:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Didn't test locally

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit c878f96 into elastic:master Aug 8, 2019
@cjcenizal cjcenizal deleted the rollup/show-create-endpoint-json branch August 8, 2019 02:51
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 8, 2019
* Switch to using EuiCodeBlock, add description text, and make request copyable.
* Align ILM request flyout.
cjcenizal added a commit that referenced this pull request Aug 8, 2019
* Switch to using EuiCodeBlock, add description text, and make request copyable.
* Align ILM request flyout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Rollups release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants