[SIEM] Toggle Column / Code Coverage and Cypress #42766

andrew-goldstein · 2019-08-06T20:20:32Z

[SIEM] Toggle Column / Code Coverage and Cypress

Features

A Toggle column checkbox for adding / removing fields in the timeline offers
an alternative to drag and drop in an expanded event:

The behavior of the Toggle field checkbox in the expanded event is the same
as the checkboxes that appear in the timeline Fields Browser.

Fixes

Pinned timeline events now use a "filled" styling when pinned instead of rotation, and unpinned events have a higher contrast in dark mode:

Before:

After (unpinned):

After (pinned):

Fixed an issue where the Copy to Clipboard icon rendered incorrectly (too
small, and not the right color):

Before:

After:

Fixed an issue where a previously invisible control became visible and
occupied additonal row space in the timeline:

Before:

After:

Fixed an issue where the timeline Fields Browser Overlaps Column Headers

Before:

After:

Code Coverage and Cypress Tests

This PR increases the jest unit test coverage for the Fields Browser, and
introduces Cypress tests for it
Added new Cypress test helpers, configuration, and test refactorings to
support running smoke tests against remote Kibana instances, including
Elastic Cloud
Refactored some Cypress tests to speed them up and reduce flakyness

https://github.com/elastic/siem-team/issues/380
https://github.com/elastic/siem-team/issues/431
https://github.com/elastic/siem-team/issues/432
https://github.com/elastic/siem-team/issues/433
https://github.com/elastic/siem-team/issues/434
https://github.com/elastic/siem-team/issues/435
https://github.com/elastic/siem-team/issues/436

elasticmachine · 2019-08-06T20:20:35Z

Pinging @elastic/siem

stephmilovic · 2019-08-07T18:40:57Z

...ck/legacy/plugins/siem/cypress/integration/smoke_tests/fields_browser/fields_browser.spec.ts

+import { HOSTS_PAGE } from '../../lib/urls';
+import { loginAndWaitForPage } from '../../lib/util/helpers';
+
+describe('Fields Browser', () => {


these are some badass tests 😎

stephmilovic · 2019-08-07T20:02:20Z

x-pack/legacy/plugins/siem/cypress/integration/smoke_tests/timeline/data_providers.ts

@@ -34,7 +29,7 @@ describe('timeline data providers', () => {
    dragFromAllHostsToTimeline();

    cy.get(TIMELINE_DROPPED_DATA_PROVIDERS, {
-      timeout: TIMELINE_RENDER_DATA_PROVIDERS_TIMEOUT,
+      timeout: DEFAULT_TIMEOUT + 10 * 1000,


Ran it a few times but still got: Timed out retrying: Expected to find element: '[data-test-subj="all-hosts"] [data-react-beautiful-dnd-drag-handle]', but never found it. :(

I'm doing some ad-hoc testing of another PR and i'm hitting timeouts in the app itself. It looks like siem-dev is not healthy ATM.

stephmilovic

LGTM once the CI is figured out and my little bitty spec question answered

x-pack/legacy/plugins/siem/cypress/integration/smoke_tests/timeline/data_providers.ts

cchaos · 2019-08-12T18:24:41Z

You may want to look into the color contrast ratios of your pin and comment icons. From what I'm seeing in the screenshot it doesn't meet AA standards.

Instead, you might consider using the $euiColorDarkShade (during dark mode) for the fill:

Also, we don't tend to rotate icons to indicate state. We already have a pinFilled icon to indicate currently pinned items. It's also a lot easier to scan and notice the contrast between the two icons. An easy way to test is to just blur your eyes a bit and see which one is easier to distinguish the differences.

elasticmachine · 2019-08-12T18:36:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

andrew-goldstein · 2019-08-13T01:16:46Z

Thanks for the feedback re: contrast and icon rotation @cchaos !

As noted in our out-of-band conversation, the pinFilled icon was added to EUI after the SIEM app adopted pin rotation as the means to differentiate between the pinned and un-pinned states.

Since pinFilled is now available and preferred over rotation to indicate the pinned state, the app has been updated to use the pinFilled icon instead of rotation.

Also, the previous implementation of pinning used EuiIcon with the subdued color, but as noted, the version of the subdued color that ships with EuiIcon does not meet the AA color contrast standard in dark mode. We changed the implementation (as suggested) from EuiIcon to EuiButtonIcon, because the subdued color that ships with EuiButtonIcon has the correct contrast in dark mode:

Before:

After (unpinned):

After (pinned):

## Features - A `Toggle column` checkbox for adding / removing fields in the timeline offers an alternative to drag and drop in an expanded event: ![toggle-field](https://user-images.githubusercontent.com/4459398/62572146-4d94c280-b850-11e9-8ff9-5feaca3f305d.gif) The behavior of the `Toggle field` checkbox in the expanded event is the same as the checkboxes that appear in the timeline _Fields Browser_. ## Fixes - Pinned timeline events now use a "filled" styling when pinned instead of rotation, and unpinned events have a higher contrast in dark mode: Before: ![unpinned-before](https://user-images.githubusercontent.com/4459398/62572175-5b4a4800-b850-11e9-9d4f-317d5abad002.png) After (unpinned): ![after-unpinned](https://user-images.githubusercontent.com/4459398/62908225-28aebc80-bd34-11e9-9237-8a98c88a6da1.png) After (pinned): ![after-pinned](https://user-images.githubusercontent.com/4459398/62908230-306e6100-bd34-11e9-9830-45d725bac5b1.png) - Fixed an issue where the `Copy to Clipboard` icon rendered incorrectly (too small, and not the right color): Before: ![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/62572224-7452f900-b850-11e9-962c-eef0b96202ff.png) After: ![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/62572240-7f0d8e00-b850-11e9-8b89-7c14bf92e705.png) - Fixed an issue where a previously invisible control became visible and occupied additonal row space in the timeline: Before: ![row-height-before](https://user-images.githubusercontent.com/4459398/62572265-8e8cd700-b850-11e9-9c36-1d74ba0ba6f5.png) After: ![row-height-after](https://user-images.githubusercontent.com/4459398/62572285-977da880-b850-11e9-8448-7085bbac8da4.png) - Fixed an issue where the timeline Fields Browser Overlaps Column Headers Before: ![field-browser-position-before](https://user-images.githubusercontent.com/4459398/62572309-a5332e00-b850-11e9-9b6f-38700d2f48a0.png) After: ![field-browser-position-after](https://user-images.githubusercontent.com/4459398/62572335-b845fe00-b850-11e9-84f8-4b273f7ef163.png) ## Code Coverage and Cypress Tests - This PR increases the `jest` unit test coverage for the _Fields Browser_, and introduces `Cypress` tests for it - Added new `Cypress` test helpers, configuration, and test refactorings to support running smoke tests against remote Kibana instances, including [Elastic Cloud](https://www.elastic.co/cloud) - Refactored some `Cypress` tests to speed them up and reduce flakyness elastic/siem-team#380 elastic/siem-team#431 elastic/siem-team#432 elastic/siem-team#433 elastic/siem-team#434 elastic/siem-team#435

elasticmachine · 2019-08-13T04:48:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…p-metrics-selectall * 'master' of github.com:elastic/kibana: (27 commits) [ML] Data Frames: Analytics job creation. (elastic#43102) [Vis Default editor] Fix issue with Rollup (elastic#42430) [Vis: Default editor] EUIficate Markdown tab (elastic#42677) [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917) [Infra UI] Add AWS metrics to node detail page (elastic#42153) update apm index pattern (elastic#43106) [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766) skip failing test (elastic#43163) [code] Add option to turn the go dependency download on/off. (elastic#43096) disable visual regression jobs Removed dead code (elastic#42774) fixes csv export of saved searches that have _source field (elastic#43123) Export missing Context types (elastic#43051) Update dependency supports-color to v7 (elastic#43064) switch to icon type string instead of node (elastic#43111) [Maps] Enable borders for icon symbols (elastic#43066) [ftr] enable visualRegression jobs (elastic#42989) [ML] Converting single to multi metric job (elastic#42532) fix(NA): dont clean dll module if it is a package json file (elastic#42904) [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635) ...

## Features - A `Toggle column` checkbox for adding / removing fields in the timeline offers an alternative to drag and drop in an expanded event: ![toggle-field](https://user-images.githubusercontent.com/4459398/62572146-4d94c280-b850-11e9-8ff9-5feaca3f305d.gif) The behavior of the `Toggle field` checkbox in the expanded event is the same as the checkboxes that appear in the timeline _Fields Browser_. ## Fixes - Pinned timeline events now use a "filled" styling when pinned instead of rotation, and unpinned events have a higher contrast in dark mode: Before: ![unpinned-before](https://user-images.githubusercontent.com/4459398/62572175-5b4a4800-b850-11e9-9d4f-317d5abad002.png) After (unpinned): ![after-unpinned](https://user-images.githubusercontent.com/4459398/62908225-28aebc80-bd34-11e9-9237-8a98c88a6da1.png) After (pinned): ![after-pinned](https://user-images.githubusercontent.com/4459398/62908230-306e6100-bd34-11e9-9830-45d725bac5b1.png) - Fixed an issue where the `Copy to Clipboard` icon rendered incorrectly (too small, and not the right color): Before: ![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/62572224-7452f900-b850-11e9-962c-eef0b96202ff.png) After: ![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/62572240-7f0d8e00-b850-11e9-8b89-7c14bf92e705.png) - Fixed an issue where a previously invisible control became visible and occupied additonal row space in the timeline: Before: ![row-height-before](https://user-images.githubusercontent.com/4459398/62572265-8e8cd700-b850-11e9-9c36-1d74ba0ba6f5.png) After: ![row-height-after](https://user-images.githubusercontent.com/4459398/62572285-977da880-b850-11e9-8448-7085bbac8da4.png) - Fixed an issue where the timeline Fields Browser Overlaps Column Headers Before: ![field-browser-position-before](https://user-images.githubusercontent.com/4459398/62572309-a5332e00-b850-11e9-9b6f-38700d2f48a0.png) After: ![field-browser-position-after](https://user-images.githubusercontent.com/4459398/62572335-b845fe00-b850-11e9-84f8-4b273f7ef163.png) ## Code Coverage and Cypress Tests - This PR increases the `jest` unit test coverage for the _Fields Browser_, and introduces `Cypress` tests for it - Added new `Cypress` test helpers, configuration, and test refactorings to support running smoke tests against remote Kibana instances, including [Elastic Cloud](https://www.elastic.co/cloud) - Refactored some `Cypress` tests to speed them up and reduce flakyness elastic/siem-team#380 elastic/siem-team#431 elastic/siem-team#432 elastic/siem-team#433 elastic/siem-team#434 elastic/siem-team#435

elasticmachine · 2019-08-13T19:17:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

@spalger

…ne / Reporting This PR contains enhancements to the `Cypress` end-to-end (e2e) testing support in the SIEM app, as discussed with @spalger Note: this PR depends on test refactorings in elastic#42766 ## New: Run `Cypress` Tests Against Elastic Cloud Cypress tests may now be run against a remote Elastic Cloud instance (override `baseUrl`), interactively or via the command line. Credentials are specified via `kibna.dev.yml` or environment variables. ## New: Run `Cypress` Tests On the Command Line Run tests on the command line (override `baseUrl` and pass credentials via the `CYPRESS_ELASTICSEARCH_USERNAME` and `CYPRESS_ELASTICSEARCH_PASSWORD` environment variables), via command line. ## New: Reporting Reports are configured to include: - An HTML report, suitable for e-mail notifications - Screenshots - Junit reports (for integration with Kibana CI) - Videos (optional) Reports generated when `Cypress` tests are run on the command line are output to the `target` directory, which follows specific conventions used by the Kibana CI process: * Any directory under `target` that begins with `kibana-`, e.g. `kibana-siem` will be uploaded as an artifact to a bucket * Junit reports are picked up from the `target/junit` directory The artifacts generated by running `Cypress` tests on the command line conform to the above conventions. ### HTML Reports An HTML report (e.g. for email notifications) is output to: ``` target/kibana-siem/cypress/results/output.html ``` ### Screenshots Screenshots of failed tests are output to: ``` target/kibana-siem/cypress/screenshots ``` ### `junit` Reports The Kibana CI process reports `junit` test results from the `target/junit` directory. Cypress `junit` reports are generated in `target/kibana-siem/cypress/results` and copied to the `target/junit` directory. ### Videos (optional) Videos are disabled by default, but can optionally be enabled by setting the `CYPRESS_video=true` environment variable: ``` CYPRESS_video=true yarn cypress:run ``` Videos are (optionally) output to: ``` target/kibana-siem/cypress/videos ``` # Updated `README` The full details and instructions for running Cypress tests are in the `siem/cypress/README.md`, which was updated to reflect the changes in this in this PR, but in a nutshell, you may run tests interactively with the following (new) environment variables: ```sh cd x-pack/legacy/plugins/siem CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:open ``` Running the command line version of the tests, which will output the reports described above, is a similar experence: ```sh cd x-pack/legacy/plugins/siem CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:run ``` elastic/siem-team#435 elastic/siem-team#437

@spalger

… / Reporting (#42804) # [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (#42804) This PR contains enhancements to the `Cypress` end-to-end (e2e) testing support in the SIEM app, as discussed with @spalger Note: this PR depends on test refactorings in #42766 ## New: Run `Cypress` Tests Against Elastic Cloud Cypress tests may now be run against a remote Elastic Cloud instance (override `baseUrl`), interactively or via the command line. Credentials are specified via `kibna.dev.yml` or environment variables. ## New: Run `Cypress` Tests On the Command Line Run tests on the command line (override `baseUrl` and pass credentials via the `CYPRESS_ELASTICSEARCH_USERNAME` and `CYPRESS_ELASTICSEARCH_PASSWORD` environment variables), via command line. ## New: Reporting Reports are configured to include: - An HTML report, suitable for e-mail notifications - Screenshots - Junit reports (for integration with Kibana CI) - Videos (optional) Reports generated when `Cypress` tests are run on the command line are output to the `target` directory, which follows specific conventions used by the Kibana CI process: * Any directory under `target` that begins with `kibana-`, e.g. `kibana-siem` will be uploaded as an artifact to a bucket * Junit reports are picked up from the `target/junit` directory The artifacts generated by running `Cypress` tests on the command line conform to the above conventions. ### HTML Reports An HTML report (e.g. for email notifications) is output to: ``` target/kibana-siem/cypress/results/output.html ``` ### Screenshots Screenshots of failed tests are output to: ``` target/kibana-siem/cypress/screenshots ``` ### `junit` Reports The Kibana CI process reports `junit` test results from the `target/junit` directory. Cypress `junit` reports are generated in `target/kibana-siem/cypress/results` and copied to the `target/junit` directory. ### Videos (optional) Videos are disabled by default, but can optionally be enabled by setting the `CYPRESS_video=true` environment variable: ``` CYPRESS_video=true yarn cypress:run ``` Videos are (optionally) output to: ``` target/kibana-siem/cypress/videos ``` # Updated `README` The full details and instructions for running Cypress tests are in the `siem/cypress/README.md`, which was updated to reflect the changes in this in this PR, but in a nutshell, you may run tests interactively with the following (new) environment variables: ```sh cd x-pack/legacy/plugins/siem CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:open ``` Running the command line version of the tests, which will output the reports described above, is a similar experence: ```sh cd x-pack/legacy/plugins/siem CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:run ``` elastic/siem-team#435 elastic/siem-team#437

@spalger

… / Reporting (elastic#42804) This PR contains enhancements to the `Cypress` end-to-end (e2e) testing support in the SIEM app, as discussed with @spalger Note: this PR depends on test refactorings in elastic#42766 Cypress tests may now be run against a remote Elastic Cloud instance (override `baseUrl`), interactively or via the command line. Credentials are specified via `kibna.dev.yml` or environment variables. Run tests on the command line (override `baseUrl` and pass credentials via the `CYPRESS_ELASTICSEARCH_USERNAME` and `CYPRESS_ELASTICSEARCH_PASSWORD` environment variables), via command line. Reports are configured to include: - An HTML report, suitable for e-mail notifications - Screenshots - Junit reports (for integration with Kibana CI) - Videos (optional) Reports generated when `Cypress` tests are run on the command line are output to the `target` directory, which follows specific conventions used by the Kibana CI process: * Any directory under `target` that begins with `kibana-`, e.g. `kibana-siem` will be uploaded as an artifact to a bucket * Junit reports are picked up from the `target/junit` directory The artifacts generated by running `Cypress` tests on the command line conform to the above conventions. An HTML report (e.g. for email notifications) is output to: ``` target/kibana-siem/cypress/results/output.html ``` Screenshots of failed tests are output to: ``` target/kibana-siem/cypress/screenshots ``` The Kibana CI process reports `junit` test results from the `target/junit` directory. Cypress `junit` reports are generated in `target/kibana-siem/cypress/results` and copied to the `target/junit` directory. Videos are disabled by default, but can optionally be enabled by setting the `CYPRESS_video=true` environment variable: ``` CYPRESS_video=true yarn cypress:run ``` Videos are (optionally) output to: ``` target/kibana-siem/cypress/videos ``` The full details and instructions for running Cypress tests are in the `siem/cypress/README.md`, which was updated to reflect the changes in this in this PR, but in a nutshell, you may run tests interactively with the following (new) environment variables: ```sh cd x-pack/legacy/plugins/siem CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:open ``` Running the command line version of the tests, which will output the reports described above, is a similar experence: ```sh cd x-pack/legacy/plugins/siem CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:run ``` elastic/siem-team#435 elastic/siem-team#437 - regen yarn.lock

@spalger

… / Reporting (#42804) (#43315) This PR contains enhancements to the `Cypress` end-to-end (e2e) testing support in the SIEM app, as discussed with @spalger Note: this PR depends on test refactorings in #42766 Cypress tests may now be run against a remote Elastic Cloud instance (override `baseUrl`), interactively or via the command line. Credentials are specified via `kibna.dev.yml` or environment variables. Run tests on the command line (override `baseUrl` and pass credentials via the `CYPRESS_ELASTICSEARCH_USERNAME` and `CYPRESS_ELASTICSEARCH_PASSWORD` environment variables), via command line. Reports are configured to include: - An HTML report, suitable for e-mail notifications - Screenshots - Junit reports (for integration with Kibana CI) - Videos (optional) Reports generated when `Cypress` tests are run on the command line are output to the `target` directory, which follows specific conventions used by the Kibana CI process: * Any directory under `target` that begins with `kibana-`, e.g. `kibana-siem` will be uploaded as an artifact to a bucket * Junit reports are picked up from the `target/junit` directory The artifacts generated by running `Cypress` tests on the command line conform to the above conventions. An HTML report (e.g. for email notifications) is output to: ``` target/kibana-siem/cypress/results/output.html ``` Screenshots of failed tests are output to: ``` target/kibana-siem/cypress/screenshots ``` The Kibana CI process reports `junit` test results from the `target/junit` directory. Cypress `junit` reports are generated in `target/kibana-siem/cypress/results` and copied to the `target/junit` directory. Videos are disabled by default, but can optionally be enabled by setting the `CYPRESS_video=true` environment variable: ``` CYPRESS_video=true yarn cypress:run ``` Videos are (optionally) output to: ``` target/kibana-siem/cypress/videos ``` The full details and instructions for running Cypress tests are in the `siem/cypress/README.md`, which was updated to reflect the changes in this in this PR, but in a nutshell, you may run tests interactively with the following (new) environment variables: ```sh cd x-pack/legacy/plugins/siem CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:open ``` Running the command line version of the tests, which will output the reports described above, is a similar experence: ```sh cd x-pack/legacy/plugins/siem CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:run ``` elastic/siem-team#435 elastic/siem-team#437 - regen yarn.lock

andrew-goldstein added release_note:enhancement release_note:fix loe:x-large Extra Large Level of Effort Team:SIEM v8.0.0 v7.4.0 labels Aug 6, 2019

andrew-goldstein force-pushed the fields-browser-tests branch from 0e63189 to 32ca927 Compare August 6, 2019 21:23

elastic deleted a comment from elasticmachine Aug 6, 2019

andrew-goldstein added the v7.3.1 label Aug 6, 2019

andrew-goldstein mentioned this pull request Aug 6, 2019

[SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting #42804

Merged

andrew-goldstein force-pushed the fields-browser-tests branch from 32ca927 to 02eafb1 Compare August 7, 2019 00:00

elastic deleted a comment from elasticmachine Aug 7, 2019

andrew-goldstein force-pushed the fields-browser-tests branch from 02eafb1 to fa85462 Compare August 7, 2019 17:28

stephmilovic reviewed Aug 7, 2019

View reviewed changes

stephmilovic requested changes Aug 7, 2019

View reviewed changes

x-pack/legacy/plugins/siem/cypress/integration/smoke_tests/timeline/data_providers.ts Show resolved Hide resolved

andrew-goldstein force-pushed the fields-browser-tests branch from fa85462 to 79362b6 Compare August 8, 2019 19:53

elastic deleted a comment from elasticmachine Aug 8, 2019

andrew-goldstein force-pushed the fields-browser-tests branch 2 times, most recently from 32b341d to da3b19c Compare August 8, 2019 21:31

elastic deleted a comment from elasticmachine Aug 8, 2019

andrew-goldstein force-pushed the fields-browser-tests branch from da3b19c to 34c4c5b Compare August 8, 2019 22:10

elastic deleted a comment from elasticmachine Aug 8, 2019

andrew-goldstein force-pushed the fields-browser-tests branch 2 times, most recently from 42471a1 to 486e2d8 Compare August 10, 2019 01:47

jgowdyelastic requested review from a team as code owners August 12, 2019 17:36

jgowdyelastic requested a review from a team August 12, 2019 17:36

andrew-goldstein removed the v7.3.1 label Aug 12, 2019

elastic deleted a comment from elasticmachine Aug 12, 2019

andrew-goldstein force-pushed the fields-browser-tests branch from 748d693 to 0342535 Compare August 13, 2019 01:10

andrew-goldstein force-pushed the fields-browser-tests branch from 0342535 to ccbf27f Compare August 13, 2019 01:57

andrew-goldstein force-pushed the fields-browser-tests branch from ccbf27f to 9b6ff9c Compare August 13, 2019 03:48

elastic deleted a comment from elasticmachine Aug 13, 2019

andrew-goldstein merged commit e731aef into elastic:master Aug 13, 2019

andrew-goldstein deleted the fields-browser-tests branch August 13, 2019 04:51

andrew-goldstein mentioned this pull request Aug 13, 2019

[7.x] [SIEM] Toggle Column / Code Coverage and Cypress (#42766) #43166

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] Toggle Column / Code Coverage and Cypress #42766

[SIEM] Toggle Column / Code Coverage and Cypress #42766

andrew-goldstein commented Aug 6, 2019 •

edited

Loading

elasticmachine commented Aug 6, 2019

stephmilovic Aug 7, 2019

stephmilovic Aug 7, 2019

andrew-goldstein Aug 7, 2019

stephmilovic left a comment

cchaos commented Aug 12, 2019

elasticmachine commented Aug 12, 2019

andrew-goldstein commented Aug 13, 2019

elasticmachine commented Aug 13, 2019

elasticmachine commented Aug 13, 2019

[SIEM] Toggle Column / Code Coverage and Cypress #42766

[SIEM] Toggle Column / Code Coverage and Cypress #42766

Conversation

andrew-goldstein commented Aug 6, 2019 • edited Loading

[SIEM] Toggle Column / Code Coverage and Cypress

Features

Fixes

Code Coverage and Cypress Tests

elasticmachine commented Aug 6, 2019

stephmilovic Aug 7, 2019

Choose a reason for hiding this comment

stephmilovic Aug 7, 2019

Choose a reason for hiding this comment

andrew-goldstein Aug 7, 2019

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

cchaos commented Aug 12, 2019

elasticmachine commented Aug 12, 2019

💚 Build Succeeded

andrew-goldstein commented Aug 13, 2019

elasticmachine commented Aug 13, 2019

💚 Build Succeeded

elasticmachine commented Aug 13, 2019

💚 Build Succeeded

andrew-goldstein commented Aug 6, 2019 •

edited

Loading