Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSL support when starting Elasticsearch from yarn es #42527

Merged
merged 10 commits into from
Aug 7, 2019
Merged

Add SSL support when starting Elasticsearch from yarn es #42527

merged 10 commits into from
Aug 7, 2019

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Aug 2, 2019 •
edited
Loading

In this PR, I'm adding --ssl support to yarn es ... commands. This will setup Elasticsearch with SSL enabled including the proper certificates it needs.

Changes include:

  • Make kbn-es support ssl
  • Making Cluster constructor take an object of options instead of log.
  • Add ssl option to Cluster constructor
  • Add fixed certificates to re-use

@mikecote mikecote added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Aug 2, 2019
@mikecote mikecote self-assigned this Aug 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine

This comment has been minimized.

Sign in to view
@mikecote mikecote marked this pull request as ready for review August 2, 2019 16:52
@mikecote mikecote added the review label Aug 2, 2019
@mikecote mikecote requested a review from a team August 2, 2019 16:53
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits

packages/kbn-es/src/cluster.js Outdated Show resolved Hide resolved
packages/kbn-es/src/cluster.js Outdated Show resolved Hide resolved
spalger
spalger reviewed Aug 6, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit

packages/kbn-es/src/constants.js Outdated Show resolved Hide resolved
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit aaea567 into elastic:master Aug 7, 2019
mikecote added a commit to mikecote/kibana that referenced this pull request Aug 7, 2019
@mikecote
Add SSL support when starting Elasticsearch from yarn es (elastic#4…
e28fb1c 
…2527)

* Initial work

* Add integration tests

* Use constants

* Fix broken code

* Handle scenario where esArgs is a string

* Remove || []

* Apply PR feedback

* Use const format
@mikecote mikecote mentioned this pull request Aug 7, 2019
Merged
mikecote added a commit that referenced this pull request Aug 7, 2019
@mikecote
Add SSL support when starting Elasticsearch from yarn es (#42527) (#…
58c91ac 
…42839)

* Initial work

* Add integration tests

* Use constants

* Fix broken code

* Handle scenario where esArgs is a string

* Remove || []

* Apply PR feedback

* Use const format
@azasypkin azasypkin mentioned this pull request Aug 8, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@mikecote mikecote

Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Operations Team label for Operations Team v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecote @elasticmachine @spalger