Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tag Cloud] Shim new platform #42348

Merged
merged 4 commits into from
Aug 5, 2019
Merged

[Tag Cloud] Shim new platform #42348

merged 4 commits into from
Aug 5, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jul 31, 2019 •
edited
Loading

Summary

Part of #41249

First step of migrating to new Platform

What was done in this PR:

  • Have a new platform-style plugin definition in typescript, with a setup method returning the public contract (see data plugin as an example). This needs to be exported from the top-level /server and/or /public directory, e.g. export foo = new Plugin.setup()
  • Be broken into logical "services", each with a service definition class (see data plugin as an example)
  • Register the visualization via the "visualizations" plugin's types service.
  • Have all static exports done from the top level plugin definition

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration labels Jul 31, 2019
@alexwizp alexwizp marked this pull request as ready for review July 31, 2019 14:32
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp self-assigned this Aug 1, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

lukeelmers
lukeelmers requested changes Aug 1, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just couple comments around converting expression functions to TS (which will need to be applied to #42240 and #39169 as well)

src/legacy/core_plugins/tagcloud/public/tag_cloud_fn.ts Outdated Show resolved Hide resolved
src/legacy/core_plugins/tagcloud/public/tag_cloud_fn.ts Outdated Show resolved Hide resolved
src/legacy/core_plugins/tagcloud/public/__snapshots__/tag_cloud_fn.test.ts.snap Outdated Show resolved Hide resolved
@elastic elastic deleted a comment from elasticmachine Aug 2, 2019
@elastic elastic deleted a comment from elasticmachine Aug 2, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp requested a review from lukeelmers August 2, 2019 13:49
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

lukeelmers
lukeelmers approved these changes Aug 5, 2019
View reviewed changes
src/legacy/core_plugins/tagcloud/public/tag_cloud_fn.ts
}),
},
},
fn(context, args) {
fn(context: Context, args: Arguments) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I didn't catch this before, but Context and Arguments are not necessary to include here... they should already be enforced by the ExpressionFunction generic.

@alexwizp alexwizp merged commit 5d3970f into elastic:master Aug 5, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 5, 2019
@alexwizp
[Tag Cloud] Shim new platform (elastic#42348)
c14f91a 
* [Tag Cloud] Shim new platform

* fix PR comments
@alexwizp alexwizp mentioned this pull request Aug 5, 2019
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/clone…
ad759ef 
…-or-edit-existing-rollup-job

* 'master' of github.com:elastic/kibana: (67 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
@lukeelmers lukeelmers mentioned this pull request Aug 5, 2019
Closed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/doc_value…
b366497 
…s_autocomplete

* 'master' of github.com:elastic/kibana: (189 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
alexwizp added a commit that referenced this pull request Aug 5, 2019
@alexwizp
[Tag Cloud] Shim new platform (#42348) (#42576)
4338974 
* [Tag Cloud] Shim new platform

* fix PR comments
@alexwizp alexwizp deleted the tag-cloud branch January 4, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@lizozom lizozom Awaiting requested review from lizozom

@streamich streamich Awaiting requested review from streamich

@thomasneirynck thomasneirynck Awaiting requested review from thomasneirynck

@nreese nreese Awaiting requested review from nreese

Assignees

@alexwizp alexwizp

Labels
Feature:NP Migration Feature:Tagcloud Tag cloud visualization feature release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexwizp @elasticmachine @lukeelmers