Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended terms panel with terms stats. #423

Closed
wants to merge 6 commits into from
Closed

Extended terms panel with terms stats. #423

wants to merge 6 commits into from

Conversation

sakalajuraj
Copy link

This pull request is related to issue #348. Terms panel is extended with opportunity to create statistics via terms stats facet. It is possible to choose mode - terms or terms_stats in terms panel.

@bobrik
Copy link

bobrik commented Sep 6, 2013

Can anyone review thins? Can't wait to see it merged.

@ricerca
Copy link

ricerca commented Sep 10, 2013

Eagerly waiting for the stats functionality to get merged.

Am sure with various statistical functions and some means of using percolation, LS + ES + Kibana is all set to be a compelling alternate for Splunk.

With due respect to splunk provided functionality, Kibana has much more promising flexibility to offer.

@spalger
Copy link
Contributor

spalger commented Sep 10, 2013

I've tried running this locally, but wasn't lucky with merging it myself. Could one of you be resolve the conflicts and get this working on the current master?

@sakalajuraj
Copy link
Author

spenceralger, can you try it now

@sakalajuraj sakalajuraj reopened this Sep 11, 2013
@sakalajuraj
Copy link
Author

Nobody interested? Really? Is there any problem?

@rashidkpc
Copy link
Contributor

There's a few things I'd like to see addressed here before this gets merged:

  • When the mode changes, the panel does not refresh
  • The stat is hard coded to 'total' while elasticsearch provides count, total_count, min, max, total and mean statistics. There should be a selector to choose the one you want to display. Since each of these comes with every response the results would not need to be refreshed when changing the value of this parameter.
  • There is no indication of what the legend values represent. See the histogram in stats mode for an example of what this should look like.
  • The table view header reads "Count" all the time, this should change with the mode and selected stat
  • The terms_stats facet does not return an 'other' value, this should be disabled when in terms_stats mode

@ingardm
Copy link

ingardm commented Oct 15, 2013

Hi guys, any chance we'll see this merged any time soon?

@rashidkpc
Copy link
Contributor

I'd love to see a terms stats mode. If anyone wants to pickup the ball and run with it, there's a short list above of changes that would be needed to the current state.

@rashidkpc
Copy link
Contributor

I'm going to go ahead and close this since there's been no movement on it

@rashidkpc rashidkpc closed this Nov 1, 2013
@bobrik bobrik mentioned this pull request Nov 3, 2013
rashidkpc added a commit that referenced this pull request Oct 6, 2014
Discover table performance/wrapping enhancement
harper-carroll pushed a commit to harper-carroll/kibana that referenced this pull request Jul 11, 2016
w33ble added a commit to w33ble/kibana that referenced this pull request Sep 13, 2018
* fix: hacky style override for .tooltip

introduced upstream in elastic#15542, which causes any .tooltip element to have a fixed width of 1px

* fix: revert 637b128

* feat: add error type tooltip icon

* chore: switch error Tooltip to TooltipIcon

several tooltips were just wrapping fa-exclamation-circle, which TooltipIcon now supports via type='error'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants