Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Add APM to Metadata Endpoint #42197

Merged
merged 9 commits into from
Aug 14, 2019
Merged

[Infra UI] Add APM to Metadata Endpoint #42197

merged 9 commits into from
Aug 14, 2019

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jul 29, 2019 •
edited
Loading

Summary

This PR adds APM feature to the GraphQL metadata endpoint for Infra UI. This is based on the work from #41836 and closes #42167.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@simianhacker simianhacker added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.4.0 labels Jul 29, 2019
@simianhacker simianhacker self-assigned this Jul 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@skh skh mentioned this pull request Jul 30, 2019
Merged
1 task
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@simianhacker simianhacker marked this pull request as ready for review August 2, 2019 20:13
@simianhacker simianhacker requested a review from a team as a code owner August 2, 2019 20:13
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@simianhacker simianhacker mentioned this pull request Aug 3, 2019
Closed
1 task
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jasonrhodes
jasonrhodes reviewed Aug 13, 2019
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the giant data and mappings files included in this PR?

@simianhacker
Copy link
Member Author

@jasonrhodes That’s the APM data for integration testing.

@jasonrhodes
Copy link
Member

@simianhacker gotcha. Seems like we can't easily test this with any of our shared environments because the host names don't match up between metricbeat and APM. Do I understand correctly that this only returns as having APM data if it finds records with APM fields that share the host name value with the currently viewed node?

We should really get the shared environment set up slightly more realistically for these kinds of cross-o11y integrations.

@simianhacker
Copy link
Member Author

@jasonrhodes The best way to test this is to use a Kubernetes host, anything that starts with opbeans-python-* should work. Go to the node detail page and inspect the response from /api/infra/metadata and you should see the APM feature in the features[] array.

@jasonrhodes
Copy link
Member

OK I see the value come back in the metadata call, for the opbeans-python kubernetes pod.

Screen Shot 2019-08-13 at 3 17 01 PM

I don't see it for the other opbeans-* pods, like opbeans-loadgen or opbeans-ruby, etc. Is that expected right now? I am not sure how this is exactly set up.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jasonrhodes
Copy link
Member

In possibly related news, sometimes I see the metadata endpoint takes about 14 seconds to resolve ... but I can't reproduce it consistently enough to get a full timing. I'll keep an eye on this.

jasonrhodes
jasonrhodes approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@simianhacker
Copy link
Member Author

@jasonrhodes We are doing is checking to see if the specific nodeId (kubernetes.pod.uid) has any documents where transaction.type and service.name fields exist in the index that's returned by `config.get('apm_oss. transactionIndices') || 'apm-*``. When I double clicked into the data for those other nodes they don't seem to be shipping data that matches that criteria.

@simianhacker simianhacker merged commit 4a1f41e into elastic:master Aug 14, 2019
@simianhacker simianhacker mentioned this pull request Aug 14, 2019
Merged
simianhacker added a commit to simianhacker/kibana that referenced this pull request Aug 14, 2019
@simianhacker
[Infra UI] Add APM to Metadata Endpoint (elastic#42197)
8a6b6dd 
* [Infra UI] Add APM to Metadata Endpoint

- Adds APM feature to metadata
- Closes elastic#42167
- Based on elastic#41836

* migrating to new http api
simianhacker added a commit that referenced this pull request Aug 14, 2019
@simianhacker
[Infra UI] Add APM to Metadata Endpoint (#42197) (#43280)
c42c0b9 
* [Infra UI] Add APM to Metadata Endpoint

- Adds APM feature to metadata
- Closes #42167
- Based on #41836

* migrating to new http api
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 15, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/rollu…
0e96e99 
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (50 commits)
  [Uptime] update monitor list configs for mobile view (elastic#43218)
  [APM] Local UI filters (elastic#41588)
  [Code] Upgrade ctags langserver (elastic#43252)
  [Code] show multiple definition results in panel (elastic#43249)
  Adds Metric Type to full screen launch tracking (elastic#42692)
  [Canvas] Convert Autocomplete to Typescript (elastic#42502)
  [telemetry] add spacesEnabled config back to xpack_main (elastic#43312)
  [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151)
  Add TLS client authentication support. (elastic#43090)
  [csp] Telemetry for csp configuration (elastic#43223)
  [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804)
  docs: add tip on agent config in a dt (elastic#43301)
  [ML] Adding bucket span estimator to new wizards (elastic#43288)
  disable flaky tests (elastic#43017)
  Fix percy target branch for PRs (elastic#43160)
  [ML] Adding post create job options (elastic#43205)
  Restore discover histogram selection triggering fetch (elastic#43097)
  Per panel time range (elastic#43153)
  [Infra UI] Add APM to Metadata Endpoint (elastic#42197)
  Sentence case copy changes (elastic#43215)
  ...
@simianhacker simianhacker mentioned this pull request Apr 23, 2020
Closed
@simianhacker simianhacker deleted the fixes-42167 branch April 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrhodes jasonrhodes jasonrhodes approved these changes

Assignees

@simianhacker simianhacker

Labels
Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Add APM feature to GraphQL Metadata Endpoint
3 participants
@simianhacker @elasticmachine @jasonrhodes