Allow migrator to run a reindex script when converting an index to an alias #41815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Team:Operations
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/core/server/saved_objects/migrations/core/build_index_map.ts
Outdated
Show resolved
Hide resolved
tylersmalley
approved these changes
Jul 23, 2019
💚 Build Succeeded |
joshdover
approved these changes
Jul 24, 2019
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jul 24, 2019
… alias (elastic#41815) * Allow migrator to run a reindex script when converting an index to an alias * Apply PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to run a script when the migrator is converting an index to an alias (example when converting
.kibana_task_managerto.kibana_task_manager_1and use saved objects, see #39829).The scenario I ran into is when converting
.kibana_task_managerto.kibana_task_manager_1. I need to prefix theidwith{type}:and was discussed (#40872) that it's best to convert using a script with the reindex.