-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elasticsearch SSL support for integration tests #41765
Merged
mikecote
merged 4 commits into
elastic:master
from
mikecote:security/enable-ssl-integration-tests
Aug 8, 2019
Merged
Add Elasticsearch SSL support for integration tests #41765
mikecote
merged 4 commits into
elastic:master
from
mikecote:security/enable-ssl-integration-tests
Aug 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mikecote
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Security
Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
v7.4.0
v8.0.0
labels
Jul 23, 2019
Pinging @elastic/kibana-security |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7 tasks
mikecote
force-pushed
the
security/enable-ssl-integration-tests
branch
from
August 7, 2019 16:12
88bac2d
to
da2f92f
Compare
mikecote
changed the title
Enable Elasticsearch SSL for integration tests with security enabled
[WIP] Add Elasticsearch SSL support for integration tests
Aug 7, 2019
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
mikecote
changed the title
[WIP] Add Elasticsearch SSL support for integration tests
Add Elasticsearch SSL support for integration tests
Aug 8, 2019
spalger
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…le-ssl-integration-tests
💔 Build Failed |
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Aug 8, 2019
* Allow tests to use SSL between Kibana and Elasticsearch * Fix cert path * By default no tests will use the new ssl feature
mikecote
added a commit
that referenced
this pull request
Aug 8, 2019
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 9, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (306 commits) [ML] Adding job overrides to the module setup endpoint (elastic#42946) [APM] Fix missing RUM url (elastic#42940) close socket timeouts without message (elastic#42456) Upgrade elastic/charts to 8.1.6 (elastic#42518) [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962) Add custom formatting for Date Nanos Format (elastic#42445) [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582) add socket.getPeerCertificate to KibanaRequest (elastic#42929) [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683) [ML] Data frames: Updated stats structure. (elastic#42923) [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841) [kbn-es] Support for passing regex value to ES (elastic#42651) Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840) Add Elasticsearch SSL support for integration tests (elastic#41765) Fix duplicate fetch in Visualize (elastic#41204) [DOCS] TSVB and Timelion clean up (elastic#42953) [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623) [APM] Use rounded bucket sizes for transaction distribution (elastic#42830) [yarn.lock] consistent resolve domain (elastic#42969) [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Security
Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
v7.4.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm modifying
kbn-test
to support connecting to Elasticsearch via SSL. I haven't enabled any test suites in this PR. This will allow alerting to createx-pack/test/alerting_api_integration
folder with a config that works with SSL.See da2f92f#diff-e8eda103b6499bbd17537a4409ffc243 for enabling SSL in your test config. The caCert will have to come from
import { CA_CERT_PATH } from '@kbn/dev-utils';
.