Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elasticsearch SSL support for integration tests #41765

Merged

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Jul 23, 2019

In this PR, I'm modifying kbn-test to support connecting to Elasticsearch via SSL. I haven't enabled any test suites in this PR. This will allow alerting to create x-pack/test/alerting_api_integration folder with a config that works with SSL.

See da2f92f#diff-e8eda103b6499bbd17537a4409ffc243 for enabling SSL in your test config. The caCert will have to come from import { CA_CERT_PATH } from '@kbn/dev-utils';.

@mikecote mikecote self-assigned this Jul 23, 2019
@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.4.0 v8.0.0 labels Jul 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine

This comment has been minimized.

@mikecote

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@mikecote

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@mikecote mikecote marked this pull request as ready for review July 24, 2019 13:10
@mikecote mikecote requested review from a team July 24, 2019 13:10
@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@mikecote mikecote force-pushed the security/enable-ssl-integration-tests branch from 88bac2d to da2f92f Compare August 7, 2019 16:12
@mikecote mikecote changed the title Enable Elasticsearch SSL for integration tests with security enabled [WIP] Add Elasticsearch SSL support for integration tests Aug 7, 2019
@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mikecote mikecote changed the title [WIP] Add Elasticsearch SSL support for integration tests Add Elasticsearch SSL support for integration tests Aug 8, 2019
@mikecote mikecote removed the request for review from a team August 8, 2019 20:16
@mikecote mikecote added the review label Aug 8, 2019
@mikecote mikecote requested a review from spalger August 8, 2019 20:16
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit cb0cabf into elastic:master Aug 8, 2019
mikecote added a commit to mikecote/kibana that referenced this pull request Aug 8, 2019
* Allow tests to use SSL between Kibana and Elasticsearch

* Fix cert path

* By default no tests will use the new ssl feature
mikecote added a commit that referenced this pull request Aug 8, 2019
* Allow tests to use SSL between Kibana and Elasticsearch

* Fix cert path

* By default no tests will use the new ssl feature
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 9, 2019
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (306 commits)
  [ML] Adding job overrides to the module setup endpoint (elastic#42946)
  [APM] Fix missing RUM url (elastic#42940)
  close socket timeouts without message (elastic#42456)
  Upgrade elastic/charts to 8.1.6 (elastic#42518)
  [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962)
  Add custom formatting for Date Nanos Format (elastic#42445)
  [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582)
  add socket.getPeerCertificate to KibanaRequest (elastic#42929)
  [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683)
  [ML] Data frames: Updated stats structure. (elastic#42923)
  [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841)
  [kbn-es] Support for passing regex value to ES (elastic#42651)
  Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840)
  Add Elasticsearch SSL support for integration tests (elastic#41765)
  Fix duplicate fetch in Visualize (elastic#41204)
  [DOCS] TSVB and Timelion clean up (elastic#42953)
  [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623)
  [APM] Use rounded bucket sizes for transaction distribution (elastic#42830)
  [yarn.lock] consistent resolve domain (elastic#42969)
  [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants