[Tile Map] Shim new Platform #41265
Merged
[Tile Map] Shim new Platform #41265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
streamich
reviewed
Jul 17, 2019
alexwizp
commented
Jul 22, 2019
| import chrome from 'ui/chrome'; | ||
|
|
||
| const WMS_MINZOOM = 0; | ||
| const WMS_MAXZOOM = 22;//increase this to 22. Better for WMS | ||
|
|
||
| const emsServiceSettings = new Promise((resolve) => { | ||
| uiModules.get('kibana').run(($injector) => { |
There was a problem hiding this comment.
@nreese please have a look.
There was a problem hiding this comment.
Yes, looks like that can be safely removed since serviceSettings is getting injected in the current version.
alexwizp
added
Feature:Coordinate Map
release_note:skip
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
lukeelmers
reviewed
Jul 23, 2019
timroes
added
Team:AppArch
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-app-arch |
|
Pinging @elastic/kibana-gis |
💚 Build Succeeded |
nreese
approved these changes
Jul 23, 2019
| return { | ||
| $injector, | ||
| // Settings for EMSClient. | ||
| // EMSClient, which currently lives in the tile_map vis, |
There was a problem hiding this comment.
EMSClient will likely be moved into its own github project and imported as an npm artifact.
https://github.com/elastic/kibana-team/issues/120
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 24, 2019
* [Table Vis] Shim new platform * cleanup * Set the correct type for the "Data" dependency
alexwizp
added a commit
that referenced
this pull request
Jul 24, 2019
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers