fix deleteAllVisualizations()

[LeeDr]

Summary

Fixes #40809

A couple of visualize tests fail because they expect to start with no existing visualizations. These tests have not typically been failing in Kibana ci because they are run in a small ci-group of tests that apparently don't leave visualizations around, or don't leave more than 1 page (10) around.

But they do fail consistently (see issue #40809) when run as part of the whole set of OSS functional UI tests or just the whole visualize app subset of those tests. So this impacts local developers and some Jenkins jobs for platforms outside of Kibana ci and Cloud.

One root problem is that the data-test-subj that we were waiting for in common_page.ensureModalOverlayHidden() is no longer there. It apparently disappeared in a change from angular to react. I don't know how to fix that, so I switched the method to look for the modal's title data-test-subj instead.
The other issue was that if there were more than one page of visualizations, the existing visualize_page.deleteAllVisualizations() wasn't going to delete more than the first page. I wrapped a retry around the deleting and looking for the empty landing page button.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[dmlemeshko]

I ran all visualize tests in a row, passing locally:

202 passing (55.0m)
48 pending

Code LGTM

[LeeDr]

@lizozom I'm going to go ahead and merge this but I'd still like to review it with you sometime soon.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[LeeDr]

retest

failed with this;

00:00:10.146 Caused: java.io.IOException: Remote call on JNLP4-connect connection from kibana-ci-immutable-centos-1563296155155503914.c.elastic-ci-prod.internal/10.224.0.126:34414 failed
00:00:10.146 	at hudson.remoting.Channel.call(Channel.java:963)
00:00:10.146 	at hudson.FilePath.act(FilePath.java:1072)
00:00:10.146 	at hudson.FilePath.act(FilePath.java:1061)
00:00:10.146 	at org.jenkinsci.plugins.gitclient.Git.getClient(Git.java:144)
00:00:10.147 	at hudson.plugins.git.GitSCM.createClient(GitSCM.java:822)
00:00:10.147 	at hudson.plugins.git.GitSCM.createClient(GitSCM.java:813)
00:00:10.147 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
00:00:10.147 	at hudson.scm.SCM.checkout(SCM.java:504)
00:00:10.147 	at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
00:00:10.147 	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
00:00:10.148 	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
00:00:10.148 	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
00:00:10.148 	at hudson.model.Run.execute(Run.java:1818)
00:00:10.148 	at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
00:00:10.148 	at hudson.model.ResourceController.execute(ResourceController.java:97)
00:00:10.148 	at hudson.model.Executor.run(Executor.java:429)

retest

[LeeDr]

retest

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[lizozom]

Sorry I didn't get to this earlier.
Looks good.