Fix aggs autocompletion in Console. #40816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
bug
|
Pinging @elastic/es-ui |
💔 Build Failed |
|
@cjcenizal that line change that you fixed was just a mistake. |
|
Retest |
alisonelizabeth
approved these changes
Jul 11, 2019
💚 Build Succeeded |
This was referenced Jul 11, 2019
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jul 11, 2019
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jul 11, 2019
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jul 11, 2019
💚 Build Succeeded |
cjcenizal
added a commit
that referenced
this pull request
Jul 11, 2019
cjcenizal
added a commit
that referenced
this pull request
Jul 11, 2019
cjcenizal
added a commit
that referenced
this pull request
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40254
When we added autocompletion support for data_frame endpoints, we made a change at this line that also seems to have caused the original bug.
The autocomplete now works as expected:
@bmcconaghy Could you share some context around this change?
@hendrikmuhs Could you test the data_frame autocompletion and make sure I haven't broken anything?
Release notes
7.2.0 introduced a regression which caused the aggs autocomplete in Console to behave incorrectly. This change fixes this bug.