De-angularize field-name directive #40744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
changed the title
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
kertal
added
v7.4.0
v8.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app |
kertal
added
the
release_note:skip
snide
reviewed
Jul 11, 2019
| @@ -169,7 +169,7 @@ discover-app { | |||
|
|
|||
| // SASSTODO: replace the margin-right value with a variables | |||
| .dscField__icon { | |||
| margin-right: 5px; | |||
| margin-right: 10px; | |||
There was a problem hiding this comment.
Since you're changing this, can you go ahead and take on that todo? Likely if you're looking for a bit more space $euiSizeS will work. It'll get you to 8px.
There was a problem hiding this comment.
Of course, we should further adapt this component, icons etc. but in a separate PR.
There was a problem hiding this comment.
i will adapt this change of course, more margin here is necessary, because react removed the whitespace angular added ... further work will include taking care of unused classes (for scripted fields e.g., guess there should be an icon for that etc.)
💚 Build Succeeded |
💚 Build Succeeded |
snide
approved these changes
Jul 11, 2019
…cover-field-name-directive
💚 Build Succeeded |
streamich
approved these changes
Jul 12, 2019
…cover-field-name-directive
💚 Build Succeeded |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 15, 2019
kertal
added a commit
that referenced
this pull request
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert the
field-namedirective from Angular to React. This is required to deangularizedoc_viewandfield_chooserofdiscover.Part of #38646
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately