Update node options Initialization on our scripts #40302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
review
Team:Operations
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
tylersmalley
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jbudz
approved these changes
Aug 1, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mistic
force-pushed
the
improve-node-options-usage
branch
from
8ebb937 to
b9db4c5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
💚 Build Succeeded |
tylersmalley
approved these changes
Aug 8, 2019
💚 Build Succeeded |
💚 Build Succeeded |
|
This good to merge? |
|
It is @tylersmalley |
|
7.x: 28fca42 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Aug 15, 2019
* chore(NA): update node options initilization on our scripts * chore(NA): re-export NODE_OPTIONS instead of re-setting on vars * chore(NA): missing doc comment
mistic
added a commit
that referenced
this pull request
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR improves our usage of the
NODE_OPTIONSenv var re-exporting theNODE_OPTIONSwith our enforced default options.That is needed because right now we are not correctly pass along the inherit
NODE_OPTIONSso for example the child processes of thethread-loaderare not receiving them.