Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary spacers and wrapping divs from Index Management confirmation modals #39971

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Remove unnecessary spacers and wrapping divs from Index Management confirmation modals #39971

merged 3 commits into from
Jul 1, 2019

Conversation

cjcenizal
Copy link
Contributor

I spotted a couple spacers which weren't necessary and then once I got into the code I also saw a few wrapping divs which could be replaced by fragments.

image

image

image

image

image

@cjcenizal cjcenizal added chore Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.3.0 labels Jun 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

cjcenizal
cjcenizal commented Jun 29, 2019
View reviewed changes
...blic/sections/index_list/components/index_actions_context_menu/index_actions_context_menu.js
);

const systemIndexModalBody = (
<div>
<EuiSpacer size="l" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spacer created too much space between title and body.

image

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal requested a review from alisonelizabeth July 1, 2019 16:29
alisonelizabeth
alisonelizabeth approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit 139f053 into elastic:master Jul 1, 2019
@cjcenizal cjcenizal deleted the chore/index-management-modal-spacer branch July 1, 2019 22:26
@cjcenizal cjcenizal mentioned this pull request Jul 1, 2019
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jul 1, 2019
@cjcenizal
Remove unnecessary spacers and wrapping divs from Index Management co…
f997610 
…nfirmation modals. (elastic#39971)
cjcenizal added a commit that referenced this pull request Jul 2, 2019
@cjcenizal
[7.x] Remove unnecessary spacers and wrapping divs from Index Managem…
780b830 
…ent confirmation modals. (#39971) (#40103)

* Remove unnecessary spacers and wrapping divs from Index Management confirmation modals. (#39971)

* Remove unused translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
chore Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.3.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @elasticmachine @alisonelizabeth