De-angularize kbn_doc_view JSON view #39515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
kertal
added
Feature:Discover
|
Pinging @elastic/kibana-app |
kertal
added
v7.3.0
v8.0.0
release_note:skip
💚 Build Succeeded |
kertal
changed the title
💔 Build Failed |
💚 Build Succeeded |
…cover-docview-json-tab
💔 Build Failed |
|
jenkins test this |
💔 Build Failed |
…cover-docview-json-tab
💚 Build Succeeded |
streamich
approved these changes
Jul 10, 2019
| }; | ||
| return { | ||
| title: i18n.translate('kbnDocViews.json.jsonTitle', { | ||
| defaultMessage: 'JSON', |
There was a problem hiding this comment.
Do we need to translate terms like JSON?
There was a problem hiding this comment.
In this case we don't translate JSON, we translate the title of the Tab, which is JSON. While it's unlikely, that it's translated to another language in a different way, it's possible. So I think it's better to handle it like the other Tab, providing a translateable title
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 10, 2019
Replace Angular code by React + EuiCodeEditor
kertal
added a commit
that referenced
this pull request
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace Angular by React at the
kbn_doc_viewplugin's JSON view as far as possible. Make use ofEuiCodeEditor. The plugin is used atDiscover:Part of #38646
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately