KibanaRequest provides headers as a property. #39506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Feature:New Platform
release_note:skip
|
Pinging @elastic/kibana-platform |
|
retest |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Jun 26, 2019
* use property instead of method. not all header names are known * fix tag name and re-generate docs
mshustov
added a commit
that referenced
this pull request
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are cases in Security and Proxy plugins when names of all headers are unknown and we still should provide access to them. I removed
getFilteredHeadersmethod and leftheadersproperty as officially supported. Later when Core supports request proxying (@toddself will create an issue) we will filter authorization headers out for all extension points, butregisterAuth.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers