-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for disabling use of triple quotes in the Console output pane. #39114
Merged
cjcenizal
merged 2 commits into
elastic:master
from
cjcenizal:console/disable-triple-quotes
Jun 19, 2019
Merged
Add setting for disabling use of triple quotes in the Console output pane. #39114
cjcenizal
merged 2 commits into
elastic:master
from
cjcenizal:console/disable-triple-quotes
Jun 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
release_note:enhancement
Feature:Console
Dev Tools Console Feature
Feature:Dev Tools
v8.0.0
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v7.3.0
labels
Jun 17, 2019
Pinging @elastic/es-ui |
💔 Build Failed |
cjcenizal
force-pushed
the
console/disable-triple-quotes
branch
from
June 19, 2019 00:42
4bab32b
to
ab6ca3e
Compare
💚 Build Succeeded |
nreese
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
code review, tested in chrome
💚 Build Succeeded |
alisonelizabeth
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Console
Dev Tools Console Feature
Feature:Dev Tools
release_note:enhancement
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v7.3.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15628
Release note
Console reformats strings which contain escaped characters by unescaping these characters and wrapping the string in triple quotes. This improves readability, but it results in invalid JSON. This is problematic for responses displayed in the output pane because people typically want to copy and paste this content elsewhere. This setting allows users to disable the use of triple quotes in the output pane, making the output JSON valid once again.