Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for disabling use of triple quotes in the Console output pane. #39114

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jun 17, 2019

Fixes #15628

Release note

Console reformats strings which contain escaped characters by unescaping these characters and wrapping the string in triple quotes. This improves readability, but it results in invalid JSON. This is problematic for responses displayed in the output pane because people typically want to copy and paste this content elsewhere. This setting allows users to disable the use of triple quotes in the output pane, making the output JSON valid once again.

image

@cjcenizal cjcenizal added release_note:enhancement Feature:Console Dev Tools Console Feature Feature:Dev Tools v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.3.0 labels Jun 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal marked this pull request as ready for review June 19, 2019 03:29
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review, tested in chrome

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make triple quoting output in console configurable
4 participants