Consolidate TimeRange, Query and Filter types. #39074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
added
chore
release_note:skip
|
Pinging @elastic/kibana-app-arch |
…ng from embeddables.
walterra
reviewed
Jun 17, 2019
| @@ -30,7 +28,7 @@ describe('FullTimeRangeSelector', () => { | |||
| }; | |||
|
|
|||
| const query: Query = { | |||
| language: QueryLanguageType.KUERY, | |||
| language: 'kuery', | |||
There was a problem hiding this comment.
Hey Stacey, can you explain why this is no longer available as an enum?
There was a problem hiding this comment.
ideally it would be, it's just that the type in the "source of truth" package always used a string, while the embeddable's one used an enum. A follow up PR could be be converting the source of truth type to use an enum. I thought about adding it in this PR... but these PRs really quickly grow in scope so tried to stick with one goal: stop importing/exporting these from the embeddables plugin.
There was a problem hiding this comment.
No comments other than this one :)
stacey-gammon
force-pushed
the
2019-06-15-remove-embedd-type-exports
branch
from
9c39a9b to
11d2118
Compare
💔 Build Failed |
💚 Build Succeeded |
lizozom
approved these changes
Jun 18, 2019
| @@ -30,7 +28,7 @@ describe('FullTimeRangeSelector', () => { | |||
| }; | |||
|
|
|||
| const query: Query = { | |||
| language: QueryLanguageType.KUERY, | |||
| language: 'kuery', | |||
There was a problem hiding this comment.
No comments other than this one :)
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 18, 2019
…ng from embeddables. (elastic#39074)
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 18, 2019
…ng from embeddables. (elastic#39074)
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 18, 2019
…ng from embeddables. (elastic#39074)
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 19, 2019
…ng from embeddables. (elastic#39074)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop exporting/importing from embedables.