[percy] only execute percy setup when necessary #39043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations |
💚 Build Succeeded |
spalger
pushed a commit
that referenced
this pull request
Jun 16, 2019
(cherry picked from commit 9c1bdb9)
|
7.x/7.3: 4cfdda4 |
spalger
pushed a commit
that referenced
this pull request
Jun 16, 2019
(cherry picked from commit 9c1bdb9)
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem on the build instances after enabling percy, because our ci setup script requires
google-chrome-stableto run successfully, but it's not available on our build instances and shouldn't be required. Instead, this pr moves the percy related setup stuff into a separate script that only runs for visual testing jobs.#33817