Separate class\type definitions from plugin instance setup #38894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin definition This helps avoiding circular dependency issues that were obsereved in filter-manager branch (due to code starting to use the data plugin).
lizozom
added
Feature:New Platform
non-issue
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Jun 15, 2019
…8894) * Separate class\type defenitions from plugin instance setup in shim plugin definition This helps avoiding circular dependency issues that were obsereved in filter-manager branch (due to code starting to use the data plugin). * typescript fun
lizozom
pushed a commit
that referenced
this pull request
Jun 16, 2019
…39039) * Separate class\type defenitions from plugin instance setup in shim plugin definition This helps avoiding circular dependency issues that were obsereved in filter-manager branch (due to code starting to use the data plugin). * typescript fun
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm having a problem with circular imports in new platform shims, and I suspect this might happen more often as we start using shim plugins around the code.
For example, as
QueryFilternow uses the data plugin, I'm getting the following dependency loop:visualize/../run_pipeline->plugins/interpreter... ->filter_manager/query_filter->plugins/data->plugins/interpreter.This PR separates class\type definitions from plugin instance setup in shim plugin definition.
I would recommend using this patterns in other shim plugins as well.
Usage
Now when you want to import any classes or types, you would import straight from the plugin
And if you want the plugin instance, you would do so through the setup file: