[Lens] Parameter configurations and new dimension config flow

x-pack/plugins/lens/public/editor_frame_plugin/editor_frame/frame_layout.tsx

@@ -20,9 +20,9 @@ export function FrameLayout(props: FrameLayoutProps) {
     <RootDragDropProvider>
       <EuiFlexGroup>
         {/* TODO style this and add workspace prop and loading flags */}
-        <EuiFlexItem>{props.dataPanel}</EuiFlexItem>
-        <EuiFlexItem>{props.workspacePanel}</EuiFlexItem>
-        <EuiFlexItem>
+        <EuiFlexItem grow={null}>{props.dataPanel}</EuiFlexItem>
+        <EuiFlexItem grow={5}>{props.workspacePanel}</EuiFlexItem>
+        <EuiFlexItem grow={null}>
           {props.configPanel}
           {props.suggestionsPanel}
         </EuiFlexItem>

x-pack/plugins/lens/public/editor_frame_plugin/editor_frame/suggestion_helpers.test.ts

@@ -30,7 +30,7 @@ describe('suggestion helpers', () => {
       'vis1',
       {}
     );
-    expect(suggestions.length).toBe(1);
+    expect(suggestions).toHaveLength(1);
     expect(suggestions[0].state).toBe(suggestedState);
   });
 
@@ -57,7 +57,7 @@ describe('suggestion helpers', () => {
       'vis1',
       {}
     );
-    expect(suggestions.length).toBe(3);
+    expect(suggestions).toHaveLength(3);
   });
 
   it('should rank the visualizations by score', () => {

x-pack/plugins/lens/public/editor_frame_plugin/editor_frame/workspace_panel.test.tsx

@@ -56,8 +56,8 @@ describe('workspace_panel', () => {
       />
     );
 
-    expect(instance.find('[data-test-subj="empty-workspace"]').length).toBe(1);
-    expect(instance.find(expressionRendererMock).length).toBe(0);
+    expect(instance.find('[data-test-subj="empty-workspace"]')).toHaveLength(1);
+    expect(instance.find(expressionRendererMock)).toHaveLength(0);
   });
 
   it('should render an explanatory text if the visualization does not produce an expression', () => {
@@ -76,8 +76,8 @@ describe('workspace_panel', () => {
       />
     );
 
-    expect(instance.find('[data-test-subj="empty-workspace"]').length).toBe(1);
-    expect(instance.find(expressionRendererMock).length).toBe(0);
+    expect(instance.find('[data-test-subj="empty-workspace"]')).toHaveLength(1);
+    expect(instance.find(expressionRendererMock)).toHaveLength(0);
   });
 
   it('should render an explanatory text if the datasource does not produce an expression', () => {
@@ -96,8 +96,8 @@ describe('workspace_panel', () => {
       />
     );
 
-    expect(instance.find('[data-test-subj="empty-workspace"]').length).toBe(1);
-    expect(instance.find(expressionRendererMock).length).toBe(0);
+    expect(instance.find('[data-test-subj="empty-workspace"]')).toHaveLength(1);
+    expect(instance.find(expressionRendererMock)).toHaveLength(0);
   });
 
   it('should render the resulting expression using the expression renderer', () => {
@@ -158,8 +158,8 @@ Object {
         />
       );
 
-      expect(instance.find('[data-test-subj="expression-failure"]').length).toBe(1);
-      expect(instance.find(expressionRendererMock).length).toBe(0);
+      expect(instance.find('[data-test-subj="expression-failure"]')).toHaveLength(1);
+      expect(instance.find(expressionRendererMock)).toHaveLength(0);
     });
 
     it('should show an error message if the expression fails to render', async () => {
@@ -191,8 +191,8 @@ Object {
 
       instance.update();
 
-      expect(instance.find('[data-test-subj="expression-failure"]').length).toBe(1);
-      expect(instance.find(expressionRendererMock).length).toBe(0);
+      expect(instance.find('[data-test-subj="expression-failure"]')).toHaveLength(1);
+      expect(instance.find(expressionRendererMock)).toHaveLength(0);
     });
 
     it('should not attempt to run the expression again if it does not change', async () => {
@@ -271,7 +271,7 @@ Object {
 
       expect(expressionRendererMock).toHaveBeenCalledTimes(2);
 
-      expect(instance.find(expressionRendererMock).length).toBe(1);
+      expect(instance.find(expressionRendererMock)).toHaveLength(1);
     });
   });
 

x-pack/plugins/lens/public/editor_frame_plugin/plugin.test.tsx

@@ -17,7 +17,7 @@ import {
 const waitForPromises = () => new Promise(resolve => setTimeout(resolve));
 
 // mock away actual data plugin to prevent all of it being loaded
-jest.mock('../../../../../src/legacy/core_plugins/data/public', () => {});
+jest.mock('../../../../../src/legacy/core_plugins/data/public/setup', () => {});
 
 describe('editor_frame plugin', () => {
   let pluginInstance: EditorFramePlugin;

x-pack/plugins/lens/public/editor_frame_plugin/plugin.tsx

@@ -8,11 +8,8 @@ import React from 'react';
 import { render, unmountComponentAtNode } from 'react-dom';
 import { I18nProvider } from '@kbn/i18n/react';
 import { CoreSetup } from 'src/core/public';
-import {
-  DataSetup,
-  data,
-  ExpressionRenderer,
-} from '../../../../../src/legacy/core_plugins/data/public';
+import { DataSetup, ExpressionRenderer } from '../../../../../src/legacy/core_plugins/data/public';
+import { data } from '../../../../../src/legacy/core_plugins/data/public/setup';
 import { Datasource, Visualization, EditorFrameSetup, EditorFrameInstance } from '../types';
 import { EditorFrame } from './editor_frame';
 

x-pack/plugins/lens/public/indexpattern_plugin/__mocks__/operations.ts

@@ -7,7 +7,7 @@
 const actual = jest.requireActual('../operations');
 
 jest.spyOn(actual, 'getPotentialColumns');
-jest.spyOn(actual, 'getColumnOrder');
+jest.spyOn(actual.operationDefinitionMap.date_histogram, 'inlineOptions');
 
 export const {
   getPotentialColumns,
@@ -16,4 +16,5 @@ export const {
   getOperationDisplay,
   getOperationTypesForField,
   getOperationResultType,
+  operationDefinitionMap,
 } = actual;

x-pack/plugins/lens/public/indexpattern_plugin/__mocks__/state_helpers.ts

@@ -0,0 +1,18 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+const actual = jest.requireActual('../state_helpers');
+
+jest.spyOn(actual, 'changeColumn');
+
+export const {
+  getColumnOrder,
+  changeColumn,
+  deleteColumn,
+  updateColumnParam,
+  sortByField,
+  hasField,
+} = actual;