[Maps] add support for Top Hits to Documents source #38052
Conversation
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
|
@gchaps I need some help with the text on this PR. Do the labels in the side editor under |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
This is really cool! Tested in Firefox. I just have a couple of concerns.
- Since this is a terms aggregation would
terma better word thanentityin the source settings? - It would be nice to have the more recent top hits draw on top of the older ones. See the screenshots below for example. Notice that the newer hits are drawn underneath older hits which leads me to misinterpret the direction the plane was traveling.
@thomasneirynck suggested using
good feedback. I can sort the list by timestamp. Would you expect items across entities to be sorted so the newest always displays on top (regardless of which entity it comes from)? Or could the sort just be local to each entity? |
💚 Build Succeeded |
💚 Build Succeeded |
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js
Show resolved
Hide resolved
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js
Show resolved
Hide resolved
| @@ -253,10 +336,30 @@ export class ESSearchSource extends AbstractESSource { | |||
| getSourceTooltipContent(sourceDataRequest) { | |||
| const featureCollection = sourceDataRequest ? sourceDataRequest.getData() : null; | |||
| const meta = sourceDataRequest ? sourceDataRequest.getMeta() : {}; | |||
There was a problem hiding this comment.
Looks like getMeta() always minimally returns an empty object so no need for this conditional assignment
There was a problem hiding this comment.
The conditional is for whether sourceDataRequest exists. Can not call getMeta on null. This statement is still needed
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js
Show resolved
Hide resolved
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/es_search_source.js
Show resolved
Hide resolved
💚 Build Succeeded |
|
Maybe we should consider not activating Save & Close if the user hasn't selected an entity since that shouldn't modify the layer and associated request (yet)
|
Lets not couple that suggestion to this PR. I can open an issue for the discussion. We have the same thing when you apply dynamic styling but do not select the field yet |
| return { | ||
| hits: resp.hits.hits, | ||
| meta: { | ||
| areResultsTrimmed: resp.hits.total > resp.hits.hits.length |
There was a problem hiding this comment.
In case _runEsQuery throws, we might want to use _.get(resp, ....) with defaults for the values here as well
There was a problem hiding this comment.
If _runEsQuery throws then it won't matter because our function will throw since _runEsQuery is not wrapped in a try/catch. This is the expected behavior so vector_layer can catch the exception and call onLoadError
* top hits * fetch top hits * trigger load if top hits configuration changes * text clean-up * add functional tests for top hits * add functional test verify configuration updates re-fetch data * show entity source tooltip message for top hits * include entities cound in results trimmed message * pass fields needed for data driven styling and joins * fix i18n problem * more i18n changes * reverse hits list so most recent events are drawn on top * review feedback * set meta to null when no sourceDataRequest
* top hits * fetch top hits * trigger load if top hits configuration changes * text clean-up * add functional tests for top hits * add functional test verify configuration updates re-fetch data * show entity source tooltip message for top hits * include entities cound in results trimmed message * pass fields needed for data driven styling and joins * fix i18n problem * more i18n changes * reverse hits list so most recent events are drawn on top * review feedback * set meta to null when no sourceDataRequest
Replaces #33320
fixes #30738
This PR updates the Documents source to allows users to use Top hits aggregation to view the most recent documents per entity. Unlike a normal search, which just returns the first 2000 results, top hits performs a terms aggregation and then gathers documents per term. This ensures that each entity will display results and can be used for use cases like "show me the last known location for each entity".