[SIEM] fix type of pinned event saved object #37515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
Team:SIEM
loe:small
|
Pinging @elastic/secops |
💔 Build Failed |
…ave x-pack security
XavierM
force-pushed
the
timeline-pinned-event-type
branch
from
ff6ab33 to
282d6f7
Compare
💚 Build Succeeded |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
May 30, 2019
…ave x-pack security (elastic#37515)
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
May 30, 2019
…ave x-pack security (elastic#37515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
what happens here that I made an assumption that createdBy and updatedBy will always be there but because security can be disable that's not true. Therefore, I just put the same type that we did for notes and timeline so it is more consistent.
https://github.com/elastic/ingest-dev/issues/460
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately