Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate fields of rollup based index patterns #37221

Merged

Conversation

kertal
Copy link
Member

@kertal kertal commented May 28, 2019

Summary

Fixes #36297 introduced by #28762. It caused the fields of rollup based index patterns to be duplicated. After the merge of rollup field data with index field data, the rollup field data was appended a second time.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

since the fields are already part of the merged version this is
the cause for displaying duplicates in the index pattern
@kertal kertal added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 Feature:Rollups v7.3.0 :KibanaApp/fix-it-week labels May 28, 2019
@kertal kertal self-assigned this May 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@kertal kertal requested review from alexwizp and cjcenizal May 28, 2019 13:27
@cjcenizal
Copy link
Contributor

Since this is a bugfix, is this worth backporting to 7.2?

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work debugging this! Tested locally, code LGTM.

image

@cjcenizal
Copy link
Contributor

cjcenizal commented May 28, 2019

@kertal Could you add Fixes {URL for original issue} to the PR description to associate the PR with the original issue? This will also auto-close the issue once this is merged.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kertal kertal added the v7.2.0 label May 28, 2019
@kertal
Copy link
Member Author

kertal commented May 28, 2019

@kertal Could you add Fixes {URL for original issue} to the PR description to associate the PR with the original issue? This will also auto-close the issue once this is merged.

of course, done

@kertal
Copy link
Member Author

kertal commented May 28, 2019

@cjcenizal what do you think about fixing duplicate data on conversion? I think rollup support is still experimental, if yes, I don't think it's necessary to fix the data

@cjcenizal
Copy link
Contributor

@kertal What's the alternative for fixing a rollup index pattern that's broken due to this bug? Recreating the index pattern and reassociating it with the dependent saved searches, visualizations, and dashboards? I could be wrong but this seems like a lot of work for the user. If so, then personally I think we owe it to the user to create the conversion. This way we can definitively state in our release notes that this bug is fixed in a specific version, since users upgrading to that version will have their index patterns magically healed.

@kertal
Copy link
Member Author

kertal commented May 28, 2019

I can recommend going to elastic meetups. there was no bug visible in the presentation of @xeraa tonight at Vienna's elastic meetup. He was using 7.1. Going back a little in the history of this bug, I found out, that it was part of a #28762, which will be part of 7.2. there's no conversion necessary, since the bug didn't make it into production, and we won't let him escape

@cjcenizal
Copy link
Contributor

🎉 Awesome!

@kertal kertal added the release_note:skip Skip the PR/issue when compiling release notes label May 29, 2019
@kertal kertal merged commit 90fdb14 into elastic:master May 29, 2019
kertal added a commit to kertal/kibana that referenced this pull request May 29, 2019
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by elastic#28762
kertal added a commit to kertal/kibana that referenced this pull request May 29, 2019
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by elastic#28762
kertal added a commit that referenced this pull request May 29, 2019
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by #28762
kertal added a commit that referenced this pull request May 29, 2019
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by #28762
@kertal kertal deleted the pr-36297-rollup-index-pattern-duplicates branch May 29, 2019 11:52
jkakavas pushed a commit to jkakavas/kibana that referenced this pull request May 30, 2019
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by elastic#28762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index Patterns app shows duplicate fields for rollup-based index patterns
4 participants