[Monitoring] Used fixed_interval explicitly for date_histogram aggregations #37023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/stack-monitoring |
💔 Build Failed |
|
@pickypg Any thoughts on this fix? Seem accurate? |
pickypg
approved these changes
May 24, 2019
There was a problem hiding this comment.
Yes, this looks appropriate, but I wonder if there are other places in our code that require this change (thinking about Beats / Logstash in particular since they have semi-unique workflows).
It would probably be easiest to run with and without this change against the latest ES master to see what gets logged as deprecated.
💚 Build Succeeded |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Aug 9, 2019
…ations (elastic#37023) * Used fixed interval explicitly * Fix tests
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Aug 9, 2019
…ations (elastic#37023) * Used fixed interval explicitly * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #27410
The
intervalfield fordate_histogramaggregations is deprecated and is replaced by either specifyingfixed_intervalorcalendar_interval. This comment leads me to believe the monitoring code should be usingfixed_interval, as ourintervalvalues arenswherenis derived bucketSize. This is actually a very simple change. Let's see how tests react.