[$multiWatch] simplified the code and fixed a race condition #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
fix/multiWatchRaceCondition
branch
from
92c6374 to
fb0282a
Compare
| @@ -34,80 +34,70 @@ define(function (require) { | |||
| * @param {boolean} deep - should the watchers be created as deep watchers? | |||
There was a problem hiding this comment.
Remove this from the docblock
spalger
force-pushed
the
fix/multiWatchRaceCondition
branch
from
fb0282a to
0759c97
Compare
|
This seems fine, but I'd like to spend some more time with it, as well as apply it against #2518 since that's how I found the original issue. In the meantime, and since this should probably have a couple sets of eyes on it anyway, I'm going to send this to @lukasolson for now. Lukas, please assign back to me after you've had a chance to check it out. |
|
I've played around with a couple areas of the application that use |
|
Looks good against #2518, and I can't find any issues with it. |
w33ble
added a commit
that referenced
this pull request
May 1, 2015
[$multiWatch] simplified the code and fixed a race condition
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue with @w33ble we noticed a race condition in
$multiWatch.When
$multiWatchtriggered the change handler, the values being passed in did not match the actual values defined on scope. This was happening because a child$scopemodifies the value being watched in the same digest cycle that the parent watcher triggers. Generally data flows top down but the filter bar is says "screw the trickle down effect!", which drew out this bug.This test was added to simulate the necessary conditions.
While considering solutions, I learned that
$watchhandlers are always executed in order, so I was able to simplify the logic and have the handler execute in exactly the same position as a normal would (as opposed to using$scope.$evalAsync)