Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Capabilities from InjectedMetadata #36710

Merged
merged 2 commits into from
May 21, 2019
Merged

Load Capabilities from InjectedMetadata #36710

merged 2 commits into from
May 21, 2019

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented May 20, 2019 •
edited
Loading

Summary

This is a temporary measure to fix loading capabilities before 7.2. This makes a small change to load capabilities from injectedMetadata until #36319 which is blocked by pending work in the New Platform's HTTP Service.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover joshdover force-pushed the capabilities-7.2-fix branch from 6eb352b to 021a0ad Compare May 20, 2019 20:23
@joshdover joshdover changed the title Temp fix for 7.2 Load Capabilities from InjectedMetadata May 20, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover joshdover force-pushed the capabilities-7.2-fix branch from 021a0ad to 0a9ba04 Compare May 20, 2019 21:23
@joshdover joshdover added Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls v7.2.0 v8.0.0 labels May 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover joshdover force-pushed the capabilities-7.2-fix branch from 0a9ba04 to 3d7fe04 Compare May 20, 2019 23:35
@joshdover joshdover marked this pull request as ready for review May 20, 2019 23:35
@joshdover joshdover requested a review from a team as a code owner May 20, 2019 23:35
@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover joshdover force-pushed the capabilities-7.2-fix branch from 3d7fe04 to d5d6864 Compare May 21, 2019 15:10
@joshdover joshdover requested a review from a team May 21, 2019 15:40
@kobelb
Copy link
Contributor

kobelb commented May 21, 2019

Ack: reviewing now.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

kobelb
kobelb approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover merged commit d9c34ca into elastic:master May 21, 2019
@joshdover joshdover deleted the capabilities-7.2-fix branch May 21, 2019 18:58
This was referenced May 21, 2019
Closed
Merged
joshdover added a commit to joshdover/kibana that referenced this pull request May 21, 2019
@joshdover
Load Capabilities from InjectedMetadata (elastic#36710)
bfa187c
joshdover added a commit that referenced this pull request May 21, 2019
@joshdover
[7.x] Load Capabilities from InjectedMetadata (#36710) (#36822)
848fd6d
@kobelb kobelb mentioned this pull request May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliperelman eliperelman eliperelman approved these changes

@kobelb kobelb kobelb approved these changes

Assignees
No one assigned
Labels
Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshdover @elasticmachine @kobelb @eliperelman