Custom legends can be specified for filter aggregates #3621
Conversation
| @@ -29,7 +29,7 @@ define(function (require) { | |||
|
|
|||
| decorateQuery(query); | |||
|
|
|||
| var label = _.deepGet(query, 'query_string.query') || angular.toJson(query); | |||
| var label = filter.label ? filter.label : (_.deepGet(query, 'query_string.query') || angular.toJson(query)); | |||
There was a problem hiding this comment.
Can you not use a ternary here? Make this hard to read.
|
This is a good start, something seems off about the label input box, spacing or something. It seems like the legend input should have a
|
|
I added a |
|
The spacing of the label on the input box is a bit more than it is for the other labels, likely due to the use of
|
|
Should be better now. |
| @@ -153,6 +153,14 @@ | |||
| font-weight: bold; | |||
| } | |||
|
|
|||
| &-growing { | |||
There was a problem hiding this comment.
Not sure on this class naming? Also, this really isn't any kind of vis-editor-agg-header
|
I updated the CSS definition. |
|
Looks good, I expect to merge this right after we cut 4.1 |
|
Great, thanks for your patience :) |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Custom legends can be specified for filter aggregates
|
Saw this merge. Even tested it out on master. Thanks! Extremely helpful! However, as of today, I'm seeing commits going to master requiring Elasticsearch 2.0.0 to run Kibana. Any plan to splice out a 4.2 Kibana release that still supports 1.4.x? |
|
Has this been in a release? |
|
^ +1. is this released? Using kibana 4.1.1 build 7489. This is really useful for simplifying dashboards for management types. |
Closes #2245
This PR allows the user to define custom labels in filter aggregates, as shown:
It's still WIP and this should also be implemented for range aggregates but it already works.
Let me know what you think :)