-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lens] Editor frame initializes datasources and visualizations #36060
Merged
wylieconlon
merged 6 commits into
elastic:feature/lens
from
wylieconlon:lens/editor-state
May 9, 2019
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0410d71
[lens] Editor frame initializes datasources and visualizations
wylieconlon 513c71e
Merge remote-tracking branch 'origin/feature/lens' into lens/editor-s…
wylieconlon b2a536a
Respond to review comments
wylieconlon 8b53dea
Fix build issues
wylieconlon eadcb28
Fix state management issue
wylieconlon d63288c
Merge branch 'feature/lens' into lens/editor-state
wylieconlon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
export * from './plugin'; |
22 changes: 22 additions & 0 deletions
22
x-pack/plugins/lens/public/xy_visualization_plugin/plugin.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { xyVisualization } from './xy_visualization'; | ||
|
||
class XyVisualizationPlugin { | ||
constructor() {} | ||
|
||
setup() { | ||
return xyVisualization; | ||
} | ||
|
||
stop() {} | ||
} | ||
|
||
const plugin = new XyVisualizationPlugin(); | ||
|
||
export const xyVisualizationSetup = () => plugin.setup(); | ||
export const xyVisualizationStop = () => plugin.stop(); |
43 changes: 43 additions & 0 deletions
43
x-pack/plugins/lens/public/xy_visualization_plugin/xy_visualization.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { xyVisualization, XyVisualizationPersistedState } from './xy_visualization'; | ||
|
||
describe('IndexPattern Data Source', () => { | ||
let persistedState: XyVisualizationPersistedState; | ||
|
||
beforeEach(() => { | ||
persistedState = { | ||
roles: [], | ||
}; | ||
}); | ||
|
||
describe('#initialize', () => { | ||
it('loads default state', () => { | ||
expect(xyVisualization.initialize()).toEqual({ | ||
roles: [], | ||
}); | ||
}); | ||
|
||
it('loads from persisted state', () => { | ||
expect(xyVisualization.initialize(persistedState)).toEqual({ | ||
roles: [], | ||
}); | ||
}); | ||
}); | ||
|
||
describe('#getPersistableState', () => { | ||
it('persists the state as given', () => { | ||
expect( | ||
xyVisualization.getPersistableState({ | ||
roles: [], | ||
}) | ||
).toEqual({ | ||
roles: [], | ||
}); | ||
}); | ||
}); | ||
}); |
37 changes: 37 additions & 0 deletions
37
x-pack/plugins/lens/public/xy_visualization_plugin/xy_visualization.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import React from 'react'; | ||
import { render } from 'react-dom'; | ||
import { Visualization, DimensionRole } from '../types'; | ||
|
||
export interface XyVisualizationState { | ||
roles: DimensionRole[]; | ||
} | ||
|
||
export type XyVisualizationPersistedState = XyVisualizationState; | ||
|
||
export const xyVisualization: Visualization<XyVisualizationState, XyVisualizationPersistedState> = { | ||
initialize() { | ||
return { | ||
roles: [], | ||
}; | ||
}, | ||
|
||
getPersistableState(state) { | ||
return state; | ||
}, | ||
|
||
renderConfigPanel: (domElement, props) => { | ||
render(<div>XY Visualization</div>, domElement); | ||
}, | ||
|
||
getSuggestions: options => [], | ||
|
||
getMappingOfTableToRoles: (state, datasource) => [], | ||
|
||
toExpression: state => '', | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't follow the
createInstance
proposal form above (and I think we should), we have to check whether render was already called on another element and clean up there: