[Uptime] Add pod and container to monitor list query #35835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
chore
v8.0.0
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime |
💔 Build Failed |
justinkambic
force-pushed
the
uptime_add-pod-and-container-to-monitor-list-query
branch
from
4345679 to
9f22cd0
Compare
…eturned from the adapter.
justinkambic
force-pushed
the
uptime_add-pod-and-container-to-monitor-list-query
branch
from
85065d4 to
5d8bc84
Compare
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
May 1, 2019
* Add test to ensure that container.id and kubernetes information are returned from the adapter. * Update GraphQL schema to reflect added Container fields. * Update monitor list query to fetch additional container/kubernetes fields. * Update API test fixtures to account for changed query. * Add copyright header to file.
justinkambic
added a commit
that referenced
this pull request
May 1, 2019
* Add test to ensure that container.id and kubernetes information are returned from the adapter. * Update GraphQL schema to reflect added Container fields. * Update monitor list query to fetch additional container/kubernetes fields. * Update API test fixtures to account for changed query. * Add copyright header to file.
justinkambic
deleted the
uptime_add-pod-and-container-to-monitor-list-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a test and additional information to our GraphQL schema/query to ensure that the desired Kubernetes and Container information are returned to the client for use with our inter-solution integrations.
Testing
If this PR is passing CI then it is largely safe to assume the changes will work.
To perform a real-world functional test, configure a Kubernetes pod and a Docker container for Heartbeat to monitor and ensure that the Pod's UID and container's ID are returned in the network requests for the Overview page.