Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception to transpile normalize-url mode to es5 when bundled into the DLL #35804

Merged
merged 6 commits into from
May 2, 2019
Merged

Add exception to transpile normalize-url mode to es5 when bundled into the DLL #35804

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13317fb
chore(NA): add resolution to prevent unsupported normalize-url path.
mistic Apr 30, 2019
d1646e1
chore(NA): resolutions for create package json task.
mistic Apr 30, 2019
84f1df3
chore(NA): extend dll compiler config with normalize url module.
mistic May 1, 2019
fb04613
Merge branch 'master' into fix-resolutions-for-normalize-url
mistic May 1, 2019
33585e1
Merge remote-tracking branch 'upstream/master' into fix-resolutions-f…
mistic May 1, 2019
490c805
chore(NA): add exclusion for normalize-url node_modules.
mistic May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/optimize/dynamic_dll_plugin/dll_config_model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ function generateDLL(config) {
test: /\.js$/,
include: /[\/\\]node_modules[\/\\]x-pack[\/\\]/,
exclude: /[\/\\]node_modules[\/\\]x-pack[\/\\](.+?[\/\\])*node_modules[\/\\]/,
},
// TODO: remove when we drop support for IE11
// We need because normalize-url is distributed without
// any kind of transpilation
// More info: https://github.com/elastic/kibana/pull/35804
{
test: /\.js$/,
include: /[\/\\]node_modules[\/\\]normalize-url[\/\\]/,
exclude: /[\/\\]node_modules[\/\\]normalize-url[\/\\](.+?[\/\\])*node_modules[\/\\]/,
}
],
// Self calling function with the equivalent logic
Expand Down