Chore: Apply redux devtools via compose #35326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes dispatching from devtools trigger other middleware
w33ble
added
chore
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
cqliu1
approved these changes
Apr 18, 2019
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Apr 19, 2019
makes dispatching from devtools trigger other middleware
w33ble
added a commit
that referenced
this pull request
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes dispatching from devtools trigger other middleware
To test, start with master (or any other branch), load a workpad, open the redux devtools, and dispatch the following action:
This will do nothing, since auto-refresh works entirely via middleware.
Next, pull down this PR and do the same thing. It should now start refreshing every 3 seconds.
Also make sure everything loads when you are not using the redux devtools (tip: use another browser, like Safari).