Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Controls - either base or feature #35321

Merged
merged 4 commits into from
Apr 19, 2019

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Apr 18, 2019

The Role Management UI only allow the user to choose between "base" or "feature" privileges for a space. While the Role Management API allowed both. This updates the API to behave like the UI for the sake of user experience consistency.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb kobelb requested a review from legrego April 19, 2019 13:50
@kobelb kobelb marked this pull request as ready for review April 19, 2019 13:50
@kobelb kobelb requested a review from a team as a code owner April 19, 2019 13:50
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kibana: [
{
base: ['all'],
feature: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@kobelb kobelb merged commit 65ac8d6 into elastic:master Apr 19, 2019
@kobelb kobelb deleted the fc/role-only-base-or-feature branch April 19, 2019 18:58
kobelb added a commit to kobelb/kibana that referenced this pull request Apr 19, 2019
* Only allowing either base or feature privileges

* Get roles route return transform error if base and feature privileges

* Treating [] and {} as undefined

* Updating the role api integration tests
kobelb added a commit that referenced this pull request Apr 19, 2019
* Only allowing either base or feature privileges

* Get roles route return transform error if base and feature privileges

* Treating [] and {} as undefined

* Updating the role api integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants