Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Add mapping for REST API test data #35249

Conversation

justinkambic
Copy link
Contributor

Summary

Mappings are currently absent for the data directory we use for Uptime's REST API. This caused some problems when backporting other test-related changes to 7.x. Specifically, certain values were being counted that would have been ignored if the proper mappings were present, which broke some API tests.

Rather than modifying that backport PR post-review to make it work, I decided it was better to open a PR to add the necessary mapping file to master first, and then backport it with an updated version number to 7.x. At that point I can remove the added mapping from the above-linked PR and retest only those changes.

Testing

If this is passing CI then it should be ok to merge.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@justinkambic justinkambic added test_xpack_functional v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.2.0 labels Apr 17, 2019
@justinkambic justinkambic requested a review from spalger April 17, 2019 19:02
@justinkambic justinkambic self-assigned this Apr 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic merged commit 1e6aae2 into elastic:master Apr 18, 2019
justinkambic added a commit to justinkambic/kibana that referenced this pull request Apr 18, 2019
justinkambic added a commit that referenced this pull request Apr 18, 2019
* Add mapping for REST API test data. (#35249)

* Update index version name to correspond to backported stack version.
@justinkambic
Copy link
Contributor Author

Backported to:
7.1.0/7.x e0a488c
#35290

@justinkambic justinkambic deleted the uptime_add-mapping-for-rest-api-test-data branch April 18, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test_xpack_functional v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants