Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Display metric rather than distribution chart for script field #34931

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Apr 11, 2019

Summary

Follow up to #34079, displays the single metric style chart in the Anomaly Explorer view for population detectors which use a script field defined in the datafeed configuration, when model plot is enabled. After the changes in #34079 a blank chart area was being displayed.

Example for a detector using high_count over highest_registered_domain with model plot enabled:

image

Note a future enhancement would be to display a distribution style chart if model plot has been enabled, but currently this style of chart can only be generated if the source data can be queried (see #21163).

Checklist

Fixes #34876

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@peteharverson peteharverson added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:ml-results legacy - do not use v8.0.0 v7.2.0 labels Apr 11, 2019
@peteharverson peteharverson requested a review from a team as a code owner April 11, 2019 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️ Just left a small comment

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alvarezmelissa87
Copy link
Contributor

Latests LGTM 🙌

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 08273e5 into elastic:master Apr 11, 2019
@peteharverson peteharverson deleted the ml-explorer-charts-population-scripted branch April 11, 2019 15:34
peteharverson added a commit to peteharverson/kibana that referenced this pull request Apr 11, 2019
…lastic#34931)

* [ML] Display metric rather than distribution chart for script field

* [ML] Cleaned up code in getChartType
peteharverson added a commit that referenced this pull request Apr 11, 2019
…34931) (#34947)

* [ML] Display metric rather than distribution chart for script field

* [ML] Cleaned up code in getChartType
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml non-issue Indicates to automation that a pull request should not appear in the release notes review v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Empty anomaly explorer charts when using a scripted field and population analysis
6 participants